Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changed the SetPolicySetting struct value to correct name in Windows NPM #2386

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

rayaisaiah
Copy link
Contributor

@rayaisaiah rayaisaiah commented Nov 13, 2023

Changed the SetPolicySetting struct PolicyType value name from "PolicyType" to "Type" in Windows NPM.

Reason for Change:
Fixes errors where the setPolicy struct had value PolicyType when it should have been Type for Windows NPM.

Issue Fixed: setPolicy struct had value PolicyType when it should have been Type. Value mismatch caused bugs.

Requirements:

@rayaisaiah rayaisaiah requested review from a team as code owners November 13, 2023 19:12
@rayaisaiah rayaisaiah changed the title fix: Changed the setPolicy struct value to correct name in Windows NPM fix: Changed the SetPolicySetting struct value to correct name in Windows NPM Nov 13, 2023
@rayaisaiah rayaisaiah enabled auto-merge (squash) November 14, 2023 00:16
@jpayne3506
Copy link
Contributor

Removes rooted dependencies from hcsshim v0.9.1 and brings in updated rooted dependencies from hcsshim v0.11.4

@jpayne3506 jpayne3506 enabled auto-merge (squash) November 15, 2023 01:16
@jpayne3506 jpayne3506 merged commit 74a67b3 into master Nov 15, 2023
102 of 109 checks passed
@jpayne3506 jpayne3506 deleted the updateSetPolicyStructValueName branch November 15, 2023 01:23
matmerr pushed a commit that referenced this pull request Jan 17, 2024
…dows NPM (#2386)

Created a new PR in non forked ACN repoo that changed the setPolicy struct PolicyType to Type in Windows NPM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants