Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph: output warnings to communicate breaking changes in the near future #7784

Merged
merged 5 commits into from
Nov 10, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/command_modules/azure-cli-role/HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

Release History
===============
2.1.10
++++++
* graph: output warnings to communicate breaking changes in the near future for "ad app/sp list"

2.1.9
++++++
* support API permission management, signed-in-user, and application password & certificate credential management
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,11 @@ def list_apps(client, app_id=None, display_name=None, identifier_uri=None, query
if identifier_uri:
sub_filters.append("identifierUris/any(s:s eq '{}')".format(identifier_uri))

if not sub_filters:
logger.warning('In a future release, if no filter arguments are provided, CLI will output only the first'
' 100 objects to minimize wait times. You can still use --all for the old behavior,'
' though it is not recommended')

return client.list(filter=(' and '.join(sub_filters)))


Expand Down Expand Up @@ -525,6 +530,10 @@ def list_sps(client, spn=None, display_name=None, query_filter=None):
if display_name:
sub_filters.append("startswith(displayName,'{}')".format(display_name))

if not sub_filters:
logger.warning('In a future release, if no filter arguments are provided, CLI will output only the first'
' 100 objects to to minimize wait times. You can still use --all for the old behavior,'
' though it is not recommended')
return client.list(filter=(' and '.join(sub_filters)))


Expand Down
2 changes: 1 addition & 1 deletion src/command_modules/azure-cli-role/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
logger.warn("Wheel is not available, disabling bdist_wheel hook")
cmdclass = {}

VERSION = "2.1.9"
VERSION = "2.1.10"

CLASSIFIERS = [
'Development Status :: 5 - Production/Stable',
Expand Down