[Compute] az vm create: Add new parameters --source-snapshots-or-disks and --source-snapshots-or-disks-size-gb to support implicit disk creation from snapshot and disk
#28949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jing-song
requested review from
zhoxing-ms,
jsntcy,
wangzelin007 and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @Jing-song, |
Jing-song
modified the milestones:
June 2024 (2024-07-02),
May 2024 (2024-05-21)❗ Breaking change release ❗
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| vm create | cmd vm create added parameter source_disk_restore_point_size_gb |
||
| vm create | cmd vm create added parameter source_disk_restore_point |
||
| vm create | cmd vm create added parameter source_snapshots_or_disks_size_gb |
||
| vm create | cmd vm create added parameter source_snapshots_or_disks |
|
Compute |
microsoft-github-policy-service
bot
added
the
Compute
Jing-song
changed the title
az vm create: Add new parameters --source-snapshots-or-disks and --source-snapshots-or-disks-size-gb to support implicit disk creation from snapshot and diskaz vm create: Add new parameters --source-snapshots-or-disks and --source-snapshots-or-disks-size-gb to support implicit disk creation from snapshot and disk
zhoxing-ms
reviewed
May 13, 2024
Comment on lines
+245
to
+249
| while source_resource_copy: | ||
| while i in used_luns: | ||
| i += 1 | ||
|
|
||
| used_luns.add(i) |
There was a problem hiding this comment.
This business logic seems difficult to understand~ Could you please add comments to explain it?
There was a problem hiding this comment.
It is an existing logic and also has comments
azure-cli/src/azure-cli/azure/cli/command_modules/vm/_vm_utils.py
Lines 244 to 259 in bb30f28
zhoxing-ms
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az vm createDescription
Implicit Disk Creation from Snapshot and Disk Restore Points
close #28686
Testing Guide
History Notes
[Compute]
az vm create: Add new parameters--source-snapshots-or-disksand--source-snapshots-or-disks-size-gbto support implicit disk creation from snapshot and disk[Compute]
az vm create: Add new parameters--source-disk-restore-pointand--source-disk-restore-point-size-gbto support implicit disk creation from disk restore pointThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.