[Storage] az storage blob sync: Add positional argument extra_options to pass through options to azcopy
#26127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelWhi
requested review from
jsntcy,
zhoxing-ms,
evelyn-ys and
calvinhzy
as code owners
️✔️acr
️✔️acs
️✔️advisor
️✔️ams
️✔️apim
️✔️appconfig
️✔️appservice
️✔️aro
️✔️backup
️✔️batch
️✔️batchai
️✔️billing
️✔️botservice
️✔️cdn
️✔️cloud
️✔️cognitiveservices
️✔️config
️✔️configure
️✔️consumption
️✔️container
️✔️core
️✔️cosmosdb
️✔️databoxedge
️✔️dla
️✔️dls
️✔️dms
️✔️eventgrid
️✔️eventhubs
️✔️feedback
️✔️find
️✔️hdinsight
️✔️identity
️✔️iot
️✔️keyvault
️✔️kusto
️✔️lab
️✔️managedservices
️✔️maps
️✔️marketplaceordering
️✔️monitor
️✔️netappfiles
️✔️network
️✔️policyinsights
️✔️privatedns
️✔️profile
️✔️rdbms
️✔️redis
️✔️relay
️✔️resource
️✔️role
️✔️search
️✔️security
️✔️servicebus
️✔️serviceconnector
️✔️servicefabric
️✔️signalr
️✔️sql
️✔️sqlvm
️✔️storage
️✔️synapse
️✔️telemetry
️✔️util
️✔️vm
|
azure-client-tools-bot-prd
bot
added this to the May 2023 (2023-05-23) - For Build (Breaking change release) milestone
|
Hi @MichaelWhi, |
ghost
added
the
customer-reported
|
Thank you for your contribution MichaelWhi! We will review the pull request and get back to you soon. |
|
Storage |
ghost
requested a review
from
MichaelWhi
changed the title
|
@MichaelWhi Thanks for contributing. From CLI design perspective, we would like to add positional argument to pass through parameters to azcopy instead of copy azcopy specific argument to cli. Similar change from #20702 for your reference |
… to pass through options to azcopy. similar to Azure#20702
MichaelWhi
force-pushed
the
feature/sync-caps
branch
from
c5b662e to
bd3e251
Compare
MichaelWhi
changed the title
Thanks @evelyn-ys for your review and comment! |
MichaelWhi
changed the title
az storage blob sync: Add positional argument extra_options to pass through options to azcopy
evelyn-ys
approved these changes
Apr 20, 2023
evelyn-ys
changed the title
az storage blob sync: Add positional argument extra_options to pass through options to azcopyaz storage blob sync: Add positional argument extra_options to pass through options to azcopy
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
…ns to pass through options to azcopy. similar to Azure#20702 (Azure#26127) Co-authored-by: Michael Whittaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az storage blob sync ... -- --cap-mbps=1.0
Description
Adds positional argument extra_options with experimental tag for flexibility, e.g. for setting an upload bandwith limit, for the blob sync command, that then will be passed to
azcopy. similar to #20702This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.
--> the underlying command (azcopy) will give an error if the cap-mbps value is not a number.