Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Make ContainerInsights DataCollectionRuleName consistent with Portal and other onboarding clients #25050

Merged
merged 4 commits into from
Jan 10, 2023

Conversation

ganga1980
Copy link
Contributor

@ganga1980 ganga1980 commented Jan 5, 2023

Related command

Description

This PR to make the ContainerInsights DCR name consistent across all the onboarding clients.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost assigned zhoxing-ms Jan 5, 2023
@ghost ghost added this to the Jan 2023 (2023-02-07) milestone Jan 5, 2023
@ghost ghost added the Auto-Assign Auto assign by bot label Jan 5, 2023
@ghost ghost requested a review from yonzhan January 5, 2023 05:19
@ghost ghost added the AKS az aks/acs/openshift label Jan 5, 2023
@ganga1980
Copy link
Contributor Author

/assign @bragi92

@ghost ghost requested a review from wangzelin007 January 5, 2023 05:19
@ghost ghost assigned jsntcy Jan 5, 2023
@ghost ghost added the Portal az portal label Jan 5, 2023
@ganga1980 ganga1980 changed the title [AKS] Make ContainerInsights DataCollectionRuleName consistent with Portal and other onboarding clients [AKS] Make ContainerInsights DataCollectionRuleName consistent with Portal and other onboarding clients Jan 5, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Jan 5, 2023

AKS

@ganga1980
Copy link
Contributor Author

Hi, @zhoxing-ms , can you please review this PR?

@zhoxing-ms zhoxing-ms merged commit 811b481 into Azure:dev Jan 10, 2023
avgale pushed a commit to avgale/azure-cli that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS az aks/acs/openshift Auto-Assign Auto assign by bot Portal az portal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants