Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] az aks create/update: Add support for KEDA workload auto-scaler #24698

Closed
wants to merge 5 commits into from

Conversation

v-shenoy
Copy link
Member

@v-shenoy v-shenoy commented Nov 21, 2022

Related command

az aks create
az aks update

Description

Allows AKS customers to enable / disable the KEDA addon for workload autoscaling.

Testing Guide

History Notes

[AKS] az aks create: Add new parameter --enable-keda to enable KEDA workload auto-scaler
[AKS] az aks update: Add new parameters --enable-keda/--disable-keda to enable/disable KEDA workload auto-scaler


This checklist is used to make sure that common guidelines for a pull request are followed.

Sorry, something went wrong.

@ghost ghost requested review from zhoxing-ms and wangzelin007 November 21, 2022 05:15
@ghost ghost assigned zhoxing-ms Nov 21, 2022
@ghost ghost added this to the Nov 2022 (2022-12-06) milestone Nov 21, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Nov 21, 2022
@ghost ghost requested a review from yonzhan November 21, 2022 05:15
@ghost ghost added the AKS az aks/acs/openshift label Nov 21, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Nov 21, 2022

AKS

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@FumingZhang
Copy link
Member

Sync changes from PR #4905 in aks-preview.


return mc

def update_workload_auto_scaler_profile(self, mc: ManagedCluster) -> ManagedCluster:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should move this function to the other class AKSManagedClusterUpdateDecorator. The function to construct the updated profile (update_mc_profile_default) is also in this class.


# create: enable-keda
create_cmd = 'aks create --resource-group={resource_group} --name={name} --location={location} --ssh-key-value={ssh_key_value} --output=json ' \
'--aks-custom-headers=AKSHTTPCustomFeatures=Microsoft.ContainerService/AKS-KedaPreview ' \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this feature still need the feature flag? If not, please remove this custom header

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, it does. Once all other changes are done for GA, we will remove the feature flag. I'll send in another PR to change that here as well.


# update: enable-keda
update_cmd = 'aks update --resource-group={resource_group} --name={name} --yes --output=json ' \
'--aks-custom-headers=AKSHTTPCustomFeatures=Microsoft.ContainerService/AKS-KedaPreview ' \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove this header if the feature is not protected by AFEC anymore.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to my reply above.

@FumingZhang
Copy link
Member

PR blocked by SDK for containerservice generated according to latest stable API 2022-11-01 not released yet.

@v-shenoy
Copy link
Member Author

v-shenoy commented Jan 3, 2023

Closing as another PR (#25007) has been raised for the same.

@v-shenoy v-shenoy closed this Jan 3, 2023
@v-shenoy v-shenoy deleted the keda-addon branch January 3, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS az aks/acs/openshift Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants