Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[App Service]
az functionapp/logicapp create
: Add new--https-only
parameter #23213[App Service]
az functionapp/logicapp create
: Add new--https-only
parameter #23213Changes from 5 commits
a44b7a7
b93efd7
e22bed8
edb9dac
3f2d96d
230fbba
ef73111
ae66a01
e3df608
a400b0f
fe2366c
0ba0123
8b219d7
1c1a551
6c4129e
a6e5472
95d0b3a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StrawnSC May I ask why
Microsoft.DomainRegistration
andMicrosoft.CertificateRegistration
don't support the new api-version asResourceType.MGMT_APPSERVICE
?If the supported api-version between them and
ResourceType.MGMT_APPSERVICE
are independent of each other, I suggest setting the sub configurations for them separately in the_shared.py
, just likeazure-cli/src/azure-cli-core/azure/cli/core/profiles/_shared.py
Lines 151 to 164 in b475906
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The App Service certs and domains back end team just released the new API version, so I just removed all the places where I was hardcoding the API version in the client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhoxing-ms this was a temporary change, while we were waiting on ARM manifest update for the new API version to complete across all locations & get the initial code review unblocked.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.