-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AD] az ad app/sp update
: Support generic update --set
on root level
#22798
Conversation
@@ -95,7 +95,7 @@ def application_delete(self, id): | |||
result = self._send("DELETE", "/applications/{id}".format(id=id)) | |||
return result | |||
|
|||
def application_patch(self, id, body): | |||
def application_update(self, id, body): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AD Graph SDK uses verb "patch", instead of "update": azure.graphrbac.operations.applications_operations.ApplicationsOperations.patch
. I guess it is used to differentiate with update_application
of generic update.
We switch to use "update" to align with other update operations (such as azure.graphrbac.operations.users_operations.UsersOperations.update
) and the API document https://docs.microsoft.com/en-us/graph/api/application-update.
The underlying functionality support of azure-cli/src/azure-cli-core/azure/cli/core/commands/arm.py Lines 502 to 503 in ce3a1f1
|
az ad app/sp update
: Support generic update --set
on root levelaz ad app/sp update
: Support generic update --set
on root level
Related command
az ad app update
az ad sp update
Description
Close #22758, #22777, #22635
az ad sp update
has no native arguments, but only generic update arguments:https://docs.microsoft.com/en-us/cli/azure/microsoft-graph-migration#known-issues documented that generic update arguments are not supported by now. Therefore,
az ad sp update
is basically a no-op.This PR is an initial attempt to makes generic update work with the new model-less framework by supporting generic update
--set
foraz ad app/sp update
on the root level: