-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQL VM] az sql vm update
: Add configuration options for SQL Assessment pre-requisites
#22672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadeveka
requested review from
zhoxing-ms,
jsntcy,
wangzelin007,
jiasli and
kairu-ms
as code owners
May 31, 2022 00:13
ghost
requested a review
from yonzhan
May 31, 2022 00:13
ghost
assigned zhoxing-ms
May 31, 2022
ghost
added this to the Jun 2022 (2022-07-05) milestone
May 31, 2022
ghost
assigned evelyn-ys
May 31, 2022
vadeveka
force-pushed
the
sqlvmassessmentv2
branch
from
May 31, 2022 00:24
06694bd
to
8521f3d
Compare
vadeveka
force-pushed
the
sqlvmassessmentv2
branch
from
May 31, 2022 01:14
2da7217
to
fbf21f0
Compare
SQL VM |
vadeveka
changed the title
[SQL VM]
[SQL VM] May 31, 2022
az sql vm update
: Add configuration options for Log Analytics pre-requisitesaz sql vm update
: Add configuration options for SQL Assessment pre-requisites
evelyn-ys
reviewed
Jun 7, 2022
evelyn-ys
reviewed
Jun 7, 2022
evelyn-ys
reviewed
Jun 7, 2022
evelyn-ys
reviewed
Jun 7, 2022
zhoxing-ms
approved these changes
Jun 9, 2022
evelyn-ys
approved these changes
Jun 10, 2022
kairu-ms
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az sql vm update --enable-assessment true -g <Resource Group Name> -n <SQL VM Name> --workspace-name <LA workspace's name> --workspace-rg <LA workspace's resource group name>
Description
az vm
's code for managing Log Analytics extension. Seesrc/azure-cli/azure/cli/command_modules/sqlvm/_util.py
SQL Best Practice Assessment
toSQL best practices assessment
as per branding requirementTesting Guide
Scenarios:
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.