Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Refactor aks nodepool update - part 1 #22050

Merged
merged 6 commits into from
Apr 14, 2022

Conversation

FumingZhang
Copy link
Member

Description

  • Refactor basic structure
  • Refactor auto scaler related properties
  • Refactor label, tag, node taint

Unit Test Coverage

  • "covered_lines": 552,
  • "num_statements": 552,
  • "percent_covered": 100.0,
  • "percent_covered_display": "100",
  • "missing_lines": 0,
  • "excluded_lines": 0

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost requested review from zhoxing-ms and wangzelin007 April 13, 2022 09:21
@ghost ghost assigned zhoxing-ms Apr 13, 2022
@ghost ghost added this to the Apr 2022 (2022-04-26) milestone Apr 13, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Apr 13, 2022
@ghost ghost requested a review from yonzhan April 13, 2022 09:22
@ghost ghost added the AKS az aks/acs/openshift label Apr 13, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 13, 2022

AKS

@FumingZhang FumingZhang marked this pull request as ready for review April 13, 2022 09:43
@zhoxing-ms zhoxing-ms merged commit 3718586 into Azure:dev Apr 14, 2022
@FumingZhang FumingZhang deleted the fuming/aks-np-update-p1 branch May 5, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS az aks/acs/openshift Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants