[App Service] az staticwebapp create: Allow creating Static Web Apps not connected to a github repo
#22042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrawnSC
requested review from
panchagnula,
jsntcy and
zhoxing-ms
as code owners
ghost
added
the
ghost
requested review from
|
App Service |
|
@anthonychu & @simonaco FYI |
panchagnula
reviewed
Apr 13, 2022
| @@ -364,8 +364,8 @@ def update_staticsite_users(cmd, name, roles, authentication_provider=None, user | |||
| static_site_user_envelope=user_envelope) | |||
|
|
|||
|
|
|||
| def create_staticsites(cmd, resource_group_name, name, location, # pylint: disable=too-many-locals, | |||
| source, branch, token=None, | |||
| def create_staticsites(cmd, resource_group_name, name, location="centralus", # pylint: disable=too-many-locals, | |||
There was a problem hiding this comment.
Did we want to make location optional & Default to CentralUs?
There was a problem hiding this comment.
Did we want to make location optional & Default to CentralUs?
Hi StrawnSC,
Can you confirm with this ?
There was a problem hiding this comment.
Yes, this is what @simonaco put on the ADO work item
panchagnula
approved these changes
Apr 13, 2022
wangzelin007
changed the title
az staticwebapp create: Allow creating Static Web Apps not connected to a github repo az staticwebapp create: Allow creating Static Web Apps not connected to a github repo
wangzelin007
approved these changes
Apr 13, 2022
zhoxing-ms
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #21058
Testing Guide
az staticwebapp create -g {} -n {}History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.