-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] Fix #20452: az storage container policy create\update\list\show\delete
: Add new permissions, currently racwdxyltmei
, Migrate to track2 sdk
#21917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned evelyn-ys
Apr 2, 2022
ghost
added this to the Apr 2022 (2022-04-26) milestone
Apr 2, 2022
Storage |
calvinhzy
changed the title
[Storage]
[Storage] Fix #20452: Apr 6, 2022
az storage container policy create\update\list\show\delete
: Migrate to track2 sdkaz storage container policy create\update\list\show\delete
: Add new permissions which is now racwdxyltmei
, Migrate to track2 sdk
calvinhzy
changed the title
[Storage] Fix #20452:
[Storage] Fix #20452: Apr 6, 2022
az storage container policy create\update\list\show\delete
: Add new permissions which is now racwdxyltmei
, Migrate to track2 sdkaz storage container policy create\update\list\show\delete
: Add new permissions which is now racwdxyltfmei
, Migrate to track2 sdk
calvinhzy
changed the title
[Storage] Fix #20452:
[Storage] Fix #20452: Apr 6, 2022
az storage container policy create\update\list\show\delete
: Add new permissions which is now racwdxyltfmei
, Migrate to track2 sdkaz storage container policy create\update\list\show\delete
: Add new permissions, currently racwdxyltfmei
, Migrate to track2 sdk
yonzhan
modified the milestones:
May 2022 (2022-05-24) - For Build,
Jun 2022 (2022-07-05)
May 21, 2022
calvinhzy
changed the title
[Storage] Fix #20452:
[Storage] Fix #20452: Jun 2, 2022
az storage container policy create\update\list\show\delete
: Add new permissions, currently racwdxyltfmei
, Migrate to track2 sdkaz storage container policy create\update\list\show\delete
: Add new permissions, currently racwdxyltmei
, Migrate to track2 sdk
calvinhzy
changed the title
[Storage] Fix #20452:
[Storage] Fix #20452: Jun 7, 2022
az storage container policy create\update\list\show\delete
: Add new permissions, currently racwdxyltmei
, Migrate to track2 sdkaz storage container policy create\update\list\show\delete
: Add new permissions, currently racwdxylftmei
, Migrate to track2 sdk
calvinhzy
changed the title
[Storage] Fix #20452:
[Storage] Fix #20452: Jun 7, 2022
az storage container policy create\update\list\show\delete
: Add new permissions, currently racwdxylftmei
, Migrate to track2 sdkaz storage container policy create\update\list\show\delete
: Add new permissions, currently racwdxyltmei
, Migrate to track2 sdk
evelyn-ys
reviewed
Jun 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You only need to transform the result of _get_acl()
then all other functions don't need to change anything
src/azure-cli/azure/cli/command_modules/storage/operations/access_policy.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/storage/operations/access_policy.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/storage/operations/access_policy.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/storage/operations/access_policy.py
Outdated
Show resolved
Hide resolved
evelyn-ys
reviewed
Jun 7, 2022
src/azure-cli/azure/cli/command_modules/storage/operations/access_policy.py
Outdated
Show resolved
Hide resolved
evelyn-ys
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #20452
Add new permissions, currently:
(a)dd (c)reate (d)elete (e)xecute (f)ilter_by_tags (i)set_immutability_policy (l)ist (m)ove (r)ead (t)ag (w)rite (x)delete_previous_version (y)permanent_delete
(f) currently not supported for all regions.
Testing Guide
az storage container policy create -c {container_name} -n {policy_name} --expiry {timestamp} --permissions racwdxyltfmei
az storage container policy show -c {container_name} -n {policy_name}
az storage container policy update -c {container_name} -n {policy_name} --permissions rwdxl --start {timestamp} --expiry {timestamp}
az storage container policy list -c {container_name}
az storage container policy delete -c {container_name} -n {policy_name}
History Notes
[Storage] Fix #20452:
az storage container policy create\update\list\show\delete
: Add new permissions, currently supportracwdxyltmei
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.