Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Fix #20452: az storage container policy create\update\list\show\delete: Add new permissions, currently racwdxyltmei, Migrate to track2 sdk #21917

Merged
merged 24 commits into from
Jun 7, 2022

Conversation

calvinhzy
Copy link
Member

@calvinhzy calvinhzy commented Apr 2, 2022

Description

Fix #20452
Add new permissions, currently:
(a)dd (c)reate (d)elete (e)xecute (f)ilter_by_tags (i)set_immutability_policy (l)ist (m)ove (r)ead (t)ag (w)rite (x)delete_previous_version (y)permanent_delete
(f) currently not supported for all regions.

Testing Guide

az storage container policy create -c {container_name} -n {policy_name} --expiry {timestamp} --permissions racwdxyltfmei
az storage container policy show -c {container_name} -n {policy_name}
az storage container policy update -c {container_name} -n {policy_name} --permissions rwdxl --start {timestamp} --expiry {timestamp}
az storage container policy list -c {container_name}
az storage container policy delete -c {container_name} -n {policy_name}

History Notes

[Storage] Fix #20452: az storage container policy create\update\list\show\delete: Add new permissions, currently support racwdxyltmei


This checklist is used to make sure that common guidelines for a pull request are followed.

@calvinhzy calvinhzy self-assigned this Apr 2, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Apr 2, 2022
@ghost ghost requested review from evelyn-ys and yonzhan April 2, 2022 09:44
@ghost ghost assigned evelyn-ys Apr 2, 2022
@ghost ghost added this to the Apr 2022 (2022-04-26) milestone Apr 2, 2022
@ghost ghost added the Storage az storage label Apr 2, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 2, 2022

Storage

@calvinhzy calvinhzy changed the title [Storage] az storage container policy create\update\list\show\delete: Migrate to track2 sdk [Storage] Fix #20452: az storage container policy create\update\list\show\delete: Add new permissions which is now racwdxyltmei, Migrate to track2 sdk Apr 6, 2022
@calvinhzy calvinhzy changed the title [Storage] Fix #20452: az storage container policy create\update\list\show\delete: Add new permissions which is now racwdxyltmei, Migrate to track2 sdk [Storage] Fix #20452: az storage container policy create\update\list\show\delete: Add new permissions which is now racwdxyltfmei, Migrate to track2 sdk Apr 6, 2022
@calvinhzy calvinhzy changed the title [Storage] Fix #20452: az storage container policy create\update\list\show\delete: Add new permissions which is now racwdxyltfmei, Migrate to track2 sdk [Storage] Fix #20452: az storage container policy create\update\list\show\delete: Add new permissions, currently racwdxyltfmei, Migrate to track2 sdk Apr 6, 2022
@yonzhan yonzhan removed this from the Apr 2022 (2022-04-26) milestone Apr 23, 2022
@calvinhzy calvinhzy marked this pull request as ready for review June 2, 2022 03:48
@calvinhzy calvinhzy changed the title [Storage] Fix #20452: az storage container policy create\update\list\show\delete: Add new permissions, currently racwdxyltfmei, Migrate to track2 sdk [Storage] Fix #20452: az storage container policy create\update\list\show\delete: Add new permissions, currently racwdxyltmei, Migrate to track2 sdk Jun 2, 2022
@calvinhzy calvinhzy changed the title [Storage] Fix #20452: az storage container policy create\update\list\show\delete: Add new permissions, currently racwdxyltmei, Migrate to track2 sdk [Storage] Fix #20452: az storage container policy create\update\list\show\delete: Add new permissions, currently racwdxylftmei, Migrate to track2 sdk Jun 7, 2022
@calvinhzy calvinhzy changed the title [Storage] Fix #20452: az storage container policy create\update\list\show\delete: Add new permissions, currently racwdxylftmei, Migrate to track2 sdk [Storage] Fix #20452: az storage container policy create\update\list\show\delete: Add new permissions, currently racwdxyltmei, Migrate to track2 sdk Jun 7, 2022
Copy link
Member

@evelyn-ys evelyn-ys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only need to transform the result of _get_acl() then all other functions don't need to change anything

@evelyn-ys evelyn-ys merged commit b413ed4 into Azure:dev Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Storage az storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access Policy for Blob Index Tags
3 participants