Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] az sql mi create, az sql mi update: Add --service-principal-type parameter to support Win Auth (Kerberos) #21872

Merged
merged 3 commits into from
Apr 15, 2022

Conversation

ReneaMoso
Copy link
Contributor

Description
Adding Service Principal parameter to az sql mi update and az sql mi create command for Windows Authentication for MI feature.

Testing Guide
A scenario test has been added for update of MI with service principal.
For manual testing: use az sql mi update and az sql mi create with --service-principal-type SystemAssigned

This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost added Auto-Assign Auto assign by bot SQL az sql labels Mar 30, 2022
@ghost ghost requested a review from yonzhan March 30, 2022 17:14
@ghost ghost assigned evelyn-ys Mar 30, 2022
@ghost ghost added this to the Mar 2022 (2022-04-06) milestone Mar 30, 2022
@ReneaMoso ReneaMoso changed the title [SQL] az sql mi create, az sql mi update: Add --service-principal-type parameter to support Win Auth (Kerberos) [SQL] az sql mi create, az sql mi update: Add --service-principal-type parameter to support Win Auth (Kerberos) Mar 30, 2022
@ReneaMoso ReneaMoso marked this pull request as draft March 30, 2022 17:34
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 30, 2022

SQL

@ReneaMoso ReneaMoso marked this pull request as ready for review March 31, 2022 13:58
@evelyn-ys
Copy link
Member

evelyn-ys commented Apr 6, 2022

It seems not following our guideline for managed identity: https://github.com/Azure/azure-cli/blob/dev/doc/managed_identity_command_guideline.md

Adding @zhoxing-ms for review

@evelyn-ys evelyn-ys requested a review from zhoxing-ms April 6, 2022 09:26
@ReneaMoso
Copy link
Contributor Author

@evelyn-ys It appears that the existing command already doesn't follow the guidelines. I have not added a new command, only added a new parameter to existing command, as per PM's request for this feature. We are not looking to change the command at this time because this feature is supposed to be released soon.

@ReneaMoso
Copy link
Contributor Author

@evelyn-ys @zhoxing-ms Could someone please review and approve this PR? The snap is in less than a week and I have not heard from anyone in a while?

Copy link
Member

@evelyn-ys evelyn-ys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Since we have not had best practice for --service-principal-type so I'd consider this PR isn't violating our guideline. I prefer to approve this PR @zhoxing-ms

Copy link
Contributor

@zhoxing-ms zhoxing-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, we have only formulated guidelines for managed identity managed_identity_command_guideline but there is no design guidelines for service principal at present. So I personally think it is not necessary to make the service principal parameters refer to the guidelines of managed identity, especially when the identity parameter itself did not follow the guideline of managed identity in sql module.

In addition, I think the service principal also needs to formulate it's own guidelines, if it's usage is similar to managed identity, then it can refer to managed identity guideline. + service principal owner @jiasli please be aware.

@evelyn-ys evelyn-ys merged commit a1b60cc into Azure:dev Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot SQL az sql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants