{Core} Discard tenant_id
in get_token
#21244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
azure-keyvault-keys==4.5.0b5
made a breaking change for authentication:It uses
azure-identity
's new multi-tenant authentication APIget_token(tenant_id=...)
fromHowever, the current authentication of Azure CLI cannot handle
get_token(tenant_id=...)
because a credential inherits from an MSAL application, sotenant_id
is fixed during the initialization of a credential/MSAL application. In order to supportget_token(tenant_id=...)
, the MSAL application must be created duringget_token
, which requires a total overhaul of the authentication mechanism.As currently Azure CLI can't automatically get an access token from another tenant for keyvault data-plane operations, we discard
tenant_id
inget_token
so that there will be no behavior change while supportingazure-keyvault-keys==4.5.0b5
.Also see: #20880