Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Core} Discard tenant_id in get_token #21244

Merged
merged 1 commit into from
Feb 11, 2022
Merged

{Core} Discard tenant_id in get_token #21244

merged 1 commit into from
Feb 11, 2022

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Feb 10, 2022

Description

azure-keyvault-keys==4.5.0b5 made a breaking change for authentication:

It uses azure-identity's new multi-tenant authentication API get_token(tenant_id=...) from

However, the current authentication of Azure CLI cannot handle get_token(tenant_id=...) because a credential inherits from an MSAL application, so tenant_id is fixed during the initialization of a credential/MSAL application. In order to support get_token(tenant_id=...), the MSAL application must be created during get_token, which requires a total overhaul of the authentication mechanism.

As currently Azure CLI can't automatically get an access token from another tenant for keyvault data-plane operations, we discard tenant_id in get_token so that there will be no behavior change while supporting azure-keyvault-keys==4.5.0b5.

Also see: #20880

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 10, 2022

Core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants