-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS] Fix incorrectly passed parameter for option --assign-kubelet-identity
in aks create sub-command
#19157
Conversation
AKS |
@FumingZhang May I ask why hasn't this issue been found in the test before? Could you add some test cases for it? |
Please specify the related commands and parameters in the PR title~ |
We do have a test case (test_aks_custom_kubelet_identity) for this command/option , but it's tagged with @live_only. So the check-in pipeline, which only runs in recording mode could not find this issue. The issue was found by the azcli aks runner, which performs live tests periodically. |
Could you describe in detail what |
I mean the |
--assign-kubelet-identity
in aks create sub-command
Description
Bug Fix. Fix incorrectly passed parameter in function "_ensure_cluster_identity_permission_on_kubelet_identity", which affects the use of custom kubelet identity. The cause of the error is the function signature change introduced by PR#18443.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.