Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Fix incorrectly passed parameter for option --assign-kubelet-identity in aks create sub-command #19157

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

FumingZhang
Copy link
Member

Description

Bug Fix. Fix incorrectly passed parameter in function "_ensure_cluster_identity_permission_on_kubelet_identity", which affects the use of custom kubelet identity. The cause of the error is the function signature change introduced by PR#18443.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 9, 2021

AKS

@yonzhan yonzhan requested a review from zhoxing-ms August 9, 2021 02:32
@yonzhan yonzhan added this to the Aug 2021 (2021-09-07) milestone Aug 9, 2021
@yonzhan yonzhan requested a review from jsntcy August 9, 2021 02:34
@FumingZhang FumingZhang marked this pull request as ready for review August 9, 2021 04:54
@FumingZhang FumingZhang requested a review from Juliehzl as a code owner August 9, 2021 04:54
@zhoxing-ms
Copy link
Contributor

@FumingZhang May I ask why hasn't this issue been found in the test before? Could you add some test cases for it?

@zhoxing-ms
Copy link
Contributor

Please specify the related commands and parameters in the PR title~

@FumingZhang
Copy link
Member Author

We do have a test case (test_aks_custom_kubelet_identity) for this command/option , but it's tagged with @live_only. So the check-in pipeline, which only runs in recording mode could not find this issue. The issue was found by the azcli aks runner, which performs live tests periodically.

@FumingZhang FumingZhang changed the title [AKS] Fix incorrectly passed parameter in kubelet_identiy [AKS] Fix incorrectly passed parameter for option --assign-kubelet-identity in create subcommand Aug 10, 2021
@zhoxing-ms
Copy link
Contributor

Could you describe in detail what create subcommand means?

@FumingZhang FumingZhang changed the title [AKS] Fix incorrectly passed parameter for option --assign-kubelet-identity in create subcommand [AKS] Fix incorrectly passed parameter for option --assign-kubelet-identity in aks create sub-command Aug 10, 2021
@FumingZhang
Copy link
Member Author

Could you describe in detail what create subcommand means?

I mean the create sub-command of the aks command group, maybe the original expression has no context and it is easy to misunderstand:sweat_smile:.

@zhoxing-ms zhoxing-ms changed the title [AKS] Fix incorrectly passed parameter for option --assign-kubelet-identity in aks create sub-command [AKS] Fix incorrectly passed parameter for option --assign-kubelet-identity in aks create sub-command Aug 11, 2021
@zhoxing-ms zhoxing-ms merged commit 65faaac into Azure:dev Aug 11, 2021
@FumingZhang FumingZhang deleted the fuming/fix-acs-kubelet branch August 11, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants