Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARM] Fix #19124: az deployment what-if: Handle unsupported and no effect change types #19144

Merged
merged 1 commit into from
Aug 6, 2021
Merged

[ARM] Fix #19124: az deployment what-if: Handle unsupported and no effect change types #19144

merged 1 commit into from
Aug 6, 2021

Conversation

shenglol
Copy link
Contributor

@shenglol shenglol commented Aug 5, 2021

Description
Fixes #19124.

Testing Guide

az deployment group/sub/mg/tenant what-if ...

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan yonzhan added this to the Aug 2021 (2021-09-07) milestone Aug 5, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Aug 5, 2021

ARM

@zhoxing-ms zhoxing-ms changed the title [ARM] Fix #19124: az deployment what-if fails to handle Unsupported and NoEffect change types [ARM] Fix #19124: az deployment what-if: Handle unsupported and no effect change types Aug 6, 2021
@zhoxing-ms
Copy link
Contributor

@shenglol Could you solve the issue of CI style and ensure that this feature passes the tests of edge build?

@zhoxing-ms zhoxing-ms merged commit 71456b1 into Azure:release Aug 6, 2021
@zhoxing-ms zhoxing-ms mentioned this pull request Aug 11, 2021
Merged
3 tasks
charliedmcb pushed a commit to charliedmcb/azure-cli that referenced this pull request Aug 16, 2021
Revert "Handle unsupported and no_effect change types (Azure#19144)"
effe159 
This reverts commit 71456b1.
charliedmcb pushed a commit to charliedmcb/azure-cli that referenced this pull request Aug 16, 2021
Revert "Revert "Handle unsupported and no_effect change types (Azure#…
33c2f04 
…19144)""

This reverts commit effe159.
charliedmcb pushed a commit to charliedmcb/azure-cli that referenced this pull request Aug 16, 2021
Revert "Handle unsupported and no_effect change types (Azure#19144)"
dbca938 
This reverts commit 71456b1.
zhoxing-ms added a commit that referenced this pull request Aug 18, 2021
@charliedmcb @zhoxing-ms
@evelyn-ys @shenglol @cRui861 @Volatus @FumingZhang @v-nestan @ericshape @adewaleo @jiasli @dpwatrous @gingi
[ACS] az aks create/update: Add parameter --auto-upgrade-channel …
6918b29 
…to support auto upgrade (#18825)

* implementedCodeFromPreviousPRs

* adding ManagedClusterAutoUpgradeProfile code

* adding test record

* Fix linter failures (#19116) (#19147)

Co-authored-by: Yishi Wang <[email protected]>

* Handle unsupported and no_effect change types (#19144)

* [Batch] Upgrade api-version to v2021-06-01 (#19100)

* Improve nodepool help text for OS Disk options (#19073)

* {AKS} Refactor acs module: add test cases for sub-command `create` (#19026)

* add test for autoscaler

* add test for loadbalancer

* add test for node public ip

* add test for network cidr

* update create default test

* add test for create attach acr

* add AKSCustomRoleBasedServicePrincipalPreparer

* update test ingress appgw

* add test case for outbound type udr

* add test for node_osdisk_diskencryptionset

* add test for enable-encryption-at-host, enable-azure-rbac, disable-rbac and dns-service-ip

* add test for workspace-resource-id

* add recordings

* update recordings

* [SQL] az sql mi update: Add --subnet and --vnet-name parameters to support the cross subnet update SLO (#18886)

* Update sql track2

* Update commands.py

update begin_delete

* update setter_name to pass sdk validation

* replace_all_delete

* pass az self-check

* update recording tests

* fix all begin_xyz issue

* run test to unblock some issues

* pass SqlServerMSSupportScenarioTest

* change region to pass tests

* pass LTR test

* add recorded tests for MI

* update db_rename parameters

* pass db management tests

* address aad tests

* pass sql server aad

* revert azure-mgmt-netapp version change

* record test after rebase

* add three passed tests

* modify short term policy

* complete another three tests

* pass tde test

* pass two more tests

* Update custom.py

* pass two more tests

* pass classification test

* pass long and short backup

* update test file to match new config

* pass server and db security tests

* record test_sql_db_sensitivity_classifications again

* update MI tests

* pass MI tests

* pass tests

* modify instance_pool_test

* Iteration 1:
- Adding support for cross subnet update SLO

* Iteration 2:
- Removing the change from History.rst file

* Iteration 3:
- Fixing merge errors

* Iteration 4:
- Removing merge errors

* Iteration 5:
- Removing merge errors

* Iteration 6:
- Fixed merge errors

* Iteration 7:
- Fix merge errors

* Iteration 7:
- Fixed CLI style issue - removed two trailing spaces
- Fixed CLI linter issue - fixed the cross-subnet update slo command in _help.py

Co-authored-by: Ji Wang <[email protected]>
Co-authored-by: Nemanja <[email protected]>

* [ACR] `acr create/update`: Add new parameter `--allow-exports` to support export (#19065)

* Update azure-mgmt-containerregistry from 8.0.0 to 8.1.0. Add support for export disable.

* Add acr export policy tests

style fix

* re-record acr dependent tests

* style: disable too many locals

* fix style issue

Co-authored-by: Tosin Adewale <[email protected]>

* Fix linter failures (#19116)

* {Packaging} Drop `mock` library (#19024)

* Upgrades Batch SDKs

* Python Data Plane SDK: 11.0.0
* Python Management Plane SDK: 16.0.0
* Fixes data plane tests

* New `outbound-endpoints` and `list-skus` commands

* `az batch account outbound-endpoints`
* `az batch location list-skus`

* Updates tests and session recordings

* Fixes help linting

Co-authored-by: Ismayil <[email protected]>
Co-authored-by: FumingZhang <[email protected]>
Co-authored-by: v-nestan <[email protected]>
Co-authored-by: Ji Wang <[email protected]>
Co-authored-by: Nemanja <[email protected]>
Co-authored-by: Tosin Adewale <[email protected]>
Co-authored-by: Tosin Adewale <[email protected]>
Co-authored-by: jiasli <[email protected]>
Co-authored-by: Yishi Wang <[email protected]>
Co-authored-by: David Watrous <[email protected]>
Co-authored-by: Shiran Pasternak <[email protected]>

* {Release} Hotfix: Release 2.27.1 (#19187)

* Hotfix for 2.27.1

* Update src/azure-cli/HISTORY.rst

Co-authored-by: Yishi Wang <[email protected]>

Co-authored-by: Yishi Wang <[email protected]>

* change to direct enums

Co-authored-by: Xing Zhou <[email protected]>

* fixing PR comments

* change to auto_upgrade_channels

* test_aks_create_with_auto_upgrade_channel

* Revert "test_aks_create_with_auto_upgrade_channel"

This reverts commit c1affbf.

* Revert "Merge branch 'master' into charliedmcb/addingAutoupgraderToCLI"

This reverts commit 4121a33, reversing
changes made to c7f92e3.

* Revert "Revert "Merge branch 'master' into charliedmcb/addingAutoupgraderToCLI""

This reverts commit ec9cd69.

* Revert "Merge branch 'master' into charliedmcb/addingAutoupgraderToCLI"

This reverts commit 4121a33, reversing
changes made to c7f92e3.

* Revert "Revert "Merge branch 'master' into charliedmcb/addingAutoupgraderToCLI""

This reverts commit 0ef331c.

* Revert "Revert "Revert "Merge branch 'master' into charliedmcb/addingAutoupgraderToCLI"""

This reverts commit cd47cb0.

* Revert "Revert "Revert "Revert "Merge branch 'master' into charliedmcb/addingAutoupgraderToCLI""""

This reverts commit 8d8f80f.

* Revert "Handle unsupported and no_effect change types (#19144)"

This reverts commit 71456b1.

* Revert "Revert "Handle unsupported and no_effect change types (#19144)""

This reverts commit effe159.

* Revert "{Release} Hotfix: Release 2.27.1 (#19187)"

This reverts commit da3ff65.

* Revert "[Batch] Upgrade api-version to v2021-06-01 (#19100)"

This reverts commit ed4e903.

* Revert "Handle unsupported and no_effect change types (#19144)"

This reverts commit 71456b1.

* running new test

* remove yaml

* ran test

Co-authored-by: Charlie McBride <[email protected]>
Co-authored-by: Xing Zhou <[email protected]>
Co-authored-by: Yishi Wang <[email protected]>
Co-authored-by: Shenglong Li <[email protected]>
Co-authored-by: Rena <[email protected]>
Co-authored-by: Ismayil <[email protected]>
Co-authored-by: FumingZhang <[email protected]>
Co-authored-by: v-nestan <[email protected]>
Co-authored-by: Ji Wang <[email protected]>
Co-authored-by: Nemanja <[email protected]>
Co-authored-by: Tosin Adewale <[email protected]>
Co-authored-by: Tosin Adewale <[email protected]>
Co-authored-by: jiasli <[email protected]>
Co-authored-by: David Watrous <[email protected]>
Co-authored-by: Shiran Pasternak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoxing-ms zhoxing-ms zhoxing-ms approved these changes

@Juliehzl Juliehzl Awaiting requested review from Juliehzl

Assignees

@zhoxing-ms zhoxing-ms

Labels
None yet
Projects
None yet
Milestone
Aug 2021 (2021-09-07)
Development

Successfully merging this pull request may close these issues.
3 participants
@shenglol @yonzhan @zhoxing-ms