-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{Redis} Migrate to Track 2 Mgmt SDK #18793
Merged
+7,308
−35
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6c27584
Update requirements.py3.Darwin.txt
gorandom 4ce457f
Update requirements.py3.Linux.txt
gorandom df689a1
Update requirements.py3.windows.txt
gorandom e84b3dd
Update setup.py
gorandom 700a026
Update commands.py
gorandom 806226b
Update custom.py
gorandom 57a1244
redis patch-schedule custom command
df0b88b
Adding new test cases and some custom commands
19e0a61
params change in custom.py
8646fb9
linter issue fix
e52d7bf
linter issue fix
639531e
removing creds from test recording.
b2875ea
removing redundant client_factory specification
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
linter issue fix
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to make these changes too? Ideally if we just define it with the right factory in commands.py, it will auto get from the SDK without a redirection here. Redisrection is required only if you want to do special cases. like first getting a Resource group before passing the name etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for redirection is to avoid a new required param "default".
The new SDK has a mandatory parameter "default" and it can take only one value "default".
I think it is the result of adding the new param in our api spec.
To avoid this mandatory parameter in CLI and to ensure backward compatibility, we have this redirection with that param included implicitly.