Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Fix failed live test case and add custom virtual network preparer #18168

Merged
merged 4 commits into from
May 24, 2021

Conversation

FumingZhang
Copy link
Member

Description

  • Fix the “test_aks_create_default_service_with_virtual_node_addon” test case in ACS module which would fail in live test.
    • Provide the same location as the resource group preparer
    • Provide a subnet address prefix to avoid conflicts with default AKS cluster cidr
  • Add a custom "AKSCustomVirtualNetworkPreparer" to replace class "VirtualNetworkPreparer" to meet the need to provide the above required resources

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan
Copy link
Collaborator

yonzhan commented May 21, 2021

AKS

@yonzhan yonzhan added this to the S188 milestone May 21, 2021
@yonzhan yonzhan requested review from zhoxing-ms and Juliehzl May 21, 2021 07:24
Copy link
Contributor

@Juliehzl Juliehzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Juliehzl Juliehzl merged commit 6810a95 into Azure:dev May 24, 2021
@FumingZhang FumingZhang deleted the fuming/fix-virtual-node branch May 24, 2021 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants