Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARM] az ts : Add UiFormDefinition file support to TemplateSpecs for GA (05/04) #17869

Merged
merged 35 commits into from
May 21, 2021
Merged

[ARM] az ts : Add UiFormDefinition file support to TemplateSpecs for GA (05/04) #17869

merged 35 commits into from
May 21, 2021

Conversation

detienne20
Copy link
Contributor

@detienne20 detienne20 commented Apr 26, 2021 •
edited
Loading

Awaiting: Azure/azure-sdk-for-python#18297 and #18142

Description

This PR bumps up the API version of TemplateSpecs and adds support for supplying an (optional) uiDefiniton file to az ts [create | update] operations. These are the final changes for Template Specs GA.

Testing Guide

az ts create -g testRG --name TemplateSpecName -v 2.0 -l WestUS --template-file
        templateSpec.json --version-description "Less simple template spec" --ui-definition-file
        templateSpecUiDefinition.json

Update:

az ts update -g ExistingRG --name ExistingName -v 3.0 -f updatedTemplate.json --display-name
        "New parent display name" --description "New parent description" --version-description "New
        child description" --ui-defintion-file updatedUiDefinition.json

zhoxing-ms
zhoxing-ms reviewed Apr 26, 2021
View reviewed changes
.vscode/launch.json Outdated Show resolved Hide resolved
@yonzhan yonzhan added this to the S186 milestone Apr 26, 2021
@zhoxing-ms
Copy link
Contributor

@detienne20 Could you please fix those CI issues?

@zhoxing-ms zhoxing-ms mentioned this pull request Apr 27, 2021
Closed
3 tasks
@detienne20 detienne20 force-pushed the daetienn/TemplateSpecs_GA branch from 7382b5b to 86a3a6c Compare May 13, 2021 16:41
@zhoxing-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Juliehzl
Juliehzl reviewed May 21, 2021
View reviewed changes
Copy link
Contributor

@Juliehzl Juliehzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for core change

@zhoxing-ms zhoxing-ms merged commit 73989ef into Azure:dev May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kairu-ms kairu-ms kairu-ms approved these changes

@Juliehzl Juliehzl Juliehzl approved these changes

@zhoxing-ms zhoxing-ms zhoxing-ms approved these changes

@evelyn-ys evelyn-ys Awaiting requested review from evelyn-ys evelyn-ys is a code owner

@fengzhou-msft fengzhou-msft Awaiting requested review from fengzhou-msft

@houk-ms houk-ms Awaiting requested review from houk-ms

@jiasli jiasli Awaiting requested review from jiasli jiasli is a code owner

@jsntcy jsntcy Awaiting requested review from jsntcy jsntcy is a code owner

@bgklein bgklein Awaiting requested review from bgklein

@dpwatrous dpwatrous Awaiting requested review from dpwatrous

@gingi gingi Awaiting requested review from gingi

@jaredmoo jaredmoo Awaiting requested review from jaredmoo

@msyyc msyyc Awaiting requested review from msyyc

@paterasMSFT paterasMSFT Awaiting requested review from paterasMSFT

@qwordy qwordy Awaiting requested review from qwordy

@yungezz yungezz Awaiting requested review from yungezz

@zqingqing1 zqingqing1 Awaiting requested review from zqingqing1

Assignees

@zhoxing-ms zhoxing-ms

Labels
None yet
Projects
None yet
Milestone
S187
Development

Successfully merging this pull request may close these issues.
6 participants
@detienne20 @zhoxing-ms @Juliehzl @kairu-ms @yonzhan @TSunny007