-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Role] az role assignment create/update
: auto complete assignee_principal_type
#17669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Role |
jiasli
reviewed
Apr 14, 2021
jiasli
reviewed
Apr 19, 2021
evelyn-ys
changed the title
[Role]
[Role] Apr 19, 2021
az role assignment create/update
: auto complete assignee_principal_type
if assignee_object_id
is providedaz role assignment create/update
: auto complete assignee_principal_type
Other references of
|
jiasli
approved these changes
Apr 21, 2021
fengzhou-msft
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature requested by #16006
When create role assignment, if
assignee
is provided withoutassignee_principal_type
, try graph call to resolve object id and get object typeobject_id
andprincipal_type
When create role assignment, if
assignee_object_id
is provided withoutassignee_principal_type
, try to get principle type from graph.assignee_principal_type
assignee_principal_type
asNone
as beforeWhen update role assignment, if
principal_type
is not provided, use the existing value ofassignment.principal_type
Testing Guide
Graph call succeed:
Graph call fail:
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.