Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Doc} Track 2 Migration Guidance #16330

Merged
merged 10 commits into from
Dec 31, 2020
Merged

{Doc} Track 2 Migration Guidance #16330

merged 10 commits into from
Dec 31, 2020

Conversation

qwordy
Copy link
Member

@qwordy qwordy commented Dec 21, 2020

Description

{Doc} Track 2 Migration Guidance

Azure CLI is built upon Azure Python SDK. Recently Azure Python SDK announced next generation product. It is named Track 2 SDK. The old version of SDK is named Track 1. It claims that it has great advantages than Track 1 SDK. It is not compatible with Track 1 SDK. Azure CLI developers need to spend considerable time and do some work to migrate from Track 1 SDK to Track 2 SDK.

This documentation summarizes typical issues and solutions when adopting Track 2 SDK in Azure CLI.

You are welcome to contribute to this documentation if you have experience of Track 2 SDK.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 21, 2020

@jsntcy for awareness.

doc/track_2_migration_guidance.md Outdated Show resolved Hide resolved
doc/track_2_migration_guidance.md Outdated Show resolved Hide resolved

**Long running operation function name change**

Long running operations have changed their function names in Track 2 SDK. A `begin_` prefix is added. E.g. `create_or_update` becomes `begin_create_or_update`. `delete` becomes `begin_delete`. It is a naming convention in Track 2 SDK to indicate that an operation is a long running operation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about add a PR link with code change to show detail for each item?


Some of property names change in Track 2 SDK.

Examples:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sample as above, sample PR is very helpful

doc/track_2_migration_guidance.md Outdated Show resolved Hide resolved
doc/track_2_migration_guidance.md Outdated Show resolved Hide resolved
doc/track_2_migration_guidance.md Outdated Show resolved Hide resolved
doc/track_2_migration_guidance.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@yonzhan yonzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsntcy we can combine our findings into this Guidance.


In DiskAccess `begin_create_or_update`, location and tags are moved to a nested structure `DiskAccess`, `disk_access = DiskAccess(location=location, tags=tags)`

### Obtaining Subscription
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to use base form of verbs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qwordy
Copy link
Member Author

qwordy commented Dec 30, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@qwordy qwordy merged commit ab2e074 into Azure:dev Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants