[MSAL]Add AAD error handling, refine SP logout #13877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qianwens
requested review from
arrownj,
fengzhou-msft,
haroldrandom,
jiasli and
Juliehzl
as code owners
|
add to S171 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jiasli
reviewed
Jun 10, 2020
| @@ -22,6 +22,8 @@ | |||
| ManagedIdentityCredential | |||
| ) | |||
|
|
|||
| from azure.core.exceptions import ClientAuthenticationError | |||
There was a problem hiding this comment.
Please delay this import to void performance downgrade. See #13843.
| id_type = self.MANAGED_IDENTITY_OBJECT_ID | ||
| authenticated = True | ||
| except ClientAuthenticationError as e: | ||
| logger.debug('MSI authentication error: %s', e.message) | ||
| logger.info('Sniff: not an MSI object id') |
There was a problem hiding this comment.
Consider using more instructive word other than Sniff. Also MSI is a deprecated name. Let's use Managed Identity.
jiasli
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.