Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] az storage container create: Fix #13373 by adding validator for public access #13496

Merged
merged 2 commits into from
May 14, 2020

Conversation

Juliehzl
Copy link
Contributor

@Juliehzl Juliehzl commented May 14, 2020

Description

Add validator for public access which will transforming "off" to None to fix #13373
Testing Guide

az storage container create -n mycontainer --account-name mysa --public-access off

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@Juliehzl Juliehzl requested a review from qianwens as a code owner May 14, 2020 07:36
@Juliehzl Juliehzl changed the title [Storage] add validator for public access [Storage] az storage container create: Fix #13373 by adding validator for public access May 14, 2020
@Juliehzl Juliehzl requested a review from zhoxing-ms May 14, 2020 07:43
Copy link
Member

@qianwens qianwens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yonzhan yonzhan added this to the S170 milestone May 14, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented May 14, 2020

add to S170

@Juliehzl Juliehzl merged commit 73ee5ce into Azure:dev May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Off' is suddenly marked as an invalid value for '--public-access'
4 participants