[Core] Knack adoption #12604
[Core] Knack adoption #12604
Conversation
jiasli
requested review from
arrownj,
fengzhou-msft,
haroldrandom,
Juliehzl and
qianwens
as code owners
|
add to S167 |
| @@ -162,7 +166,8 @@ def show_help(self, cli_name, nouns, parser, is_group): | |||
| AzCliHelp.update_examples(help_file) | |||
| self._print_detailed_help(cli_name, help_file) | |||
|
|
|||
| print(SURVEY_PROMPT) | |||
| from colorama import Fore, Style | |||
There was a problem hiding this comment.
from colorama import Fore, Style [](start = 8, length = 32)
suggest to add some description in PR about colorama changes, I cannot understand the difference between colorama.init(autoreset=True) and use from colorama import Fore, Style
There was a problem hiding this comment.
This is really a long store about terminal coloring. You may check the colorama doc https://pypi.org/project/colorama/ for its usage. colorama.init(autoreset=True) logic has been moved to Knack.
This line is redundant. Let's remove it.
| SURVEY_PROMPT = Fore.YELLOW + Style.BRIGHT + 'Please let us know how we are doing: ' + Fore.BLUE \ | ||
| + 'https://aka.ms/clihats' + Style.RESET_ALL | ||
| SURVEY_PROMPT = 'Please let us know how we are doing: https://aka.ms/clihats' | ||
| SURVEY_PROMPT_COLOR = Fore.YELLOW + Style.BRIGHT + 'Please let us know how we are doing: ' + Fore.BLUE \ |
There was a problem hiding this comment.
you can add some snapshot in PR description for this kind of ux change
There was a problem hiding this comment.
Nice idea!
Originally with color:
After running $Env:AZURE_CORE_NO_COLOR='true'. It becomes
|
Could resolve conflict and errors first? |
This is because Knack is not released and the dependency is missing. Could you please take a look at microsoft/knack#181? |
# Conflicts: # src/azure-cli-core/azure/cli/core/extension/operations.py
History Notes:
[Core] PREVIEW: Allow disabling color by setting
AZURE_CORE_NO_COLORenvironment variable toTrueor[core] no_color=Trueconfig (#12601)[Core] PREVIEW: Add
--only-show-errorsglobal argument to mute all warning, info and debug output. It can also be enabled by settingAZURE_CORE_ONLY_SHOW_ERRORSenvironment variable toTrueor[core] only_show_errors=Trueconfig (#12544)[Core] PREVIEW: Add experimental tag to command groups, commands and arguments (#12543)
{Core} Move yaml output to Knack (#12603)
This PR applies changes of microsoft/knack#181.