-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQL DB, SQL MI] Add minimal_tls_version property for MI and SQL DB #12414
Changes from 18 commits
35b5e3c
9662889
d8a09da
0914271
1d0dd71
0a221dd
11c5c0e
632fe0e
6683435
c595747
7fcc7f7
c8f0e1f
6e396c1
24915a9
218de31
0a06276
4f53792
f9e82ae
859cec2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -442,6 +442,19 @@ class FailoverPolicyType(Enum): | |
manual = 'Manual' | ||
|
||
|
||
class SqlServerMinimalTlsVersionType(Enum): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should have defined this enum in swagger so that it showed up in generated sdk. Then you wouldn't need to define it here. This is what I was asking about on your swagger review. :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, sorry about that, we have plans to fix it and do it the right way :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you, please do :) |
||
tls_1_0 = "1.0" | ||
tls_1_1 = "1.1" | ||
tls_1_2 = "1.2" | ||
|
||
|
||
class SqlManagedInstanceMinimalTlsVersionType(Enum): | ||
no_tls = "None" | ||
tls_1_0 = "1.0" | ||
tls_1_1 = "1.1" | ||
tls_1_2 = "1.2" | ||
|
||
|
||
class ComputeModelType(str, Enum): | ||
|
||
provisioned = "Provisioned" | ||
|
@@ -2007,7 +2020,8 @@ def server_list( | |
def server_update( | ||
instance, | ||
administrator_login_password=None, | ||
assign_identity=False): | ||
assign_identity=False, | ||
minimal_tls_version=None): | ||
''' | ||
Updates a server. Custom update function to apply parameters to instance. | ||
''' | ||
|
@@ -2019,6 +2033,8 @@ def server_update( | |
# Apply params to instance | ||
instance.administrator_login_password = ( | ||
administrator_login_password or instance.administrator_login_password) | ||
instance.minimal_tls_version = ( | ||
minimal_tls_version or instance.minimal_tls_version) | ||
|
||
return instance | ||
|
||
|
@@ -2359,7 +2375,8 @@ def managed_instance_update( | |
proxy_override=None, | ||
public_data_endpoint_enabled=None, | ||
tier=None, | ||
family=None): | ||
family=None, | ||
minimal_tls_version=None): | ||
''' | ||
Updates a managed instance. Custom update function to apply parameters to instance. | ||
''' | ||
|
@@ -2379,6 +2396,8 @@ def managed_instance_update( | |
storage_size_in_gb or instance.storage_size_in_gb) | ||
instance.proxy_override = ( | ||
proxy_override or instance.proxy_override) | ||
instance.minimal_tls_version = ( | ||
minimal_tls_version or instance.minimal_tls_version) | ||
|
||
instance.sku.name = None | ||
instance.sku.tier = ( | ||
|
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is_preview=True
to give a sprint time to test the parameter behavior with the following flag?