-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AppConfig]Add customer managed key when updating stores. #12102
Changes from 3 commits
37b2bda
0895dcc
546ffe4
e8852e9
371448f
fc73bad
93cb3f5
d45b6f5
219f80a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -79,6 +79,12 @@ def load_arguments(self, _): | |
with self.argument_context('appconfig update') as c: | ||
c.argument('tags', arg_type=tags_type) | ||
|
||
with self.argument_context('appconfig update', arg_group='Customer Managed Key', is_preview=True) as c: | ||
c.argument('encryption_key_name', help='The name of the KeyVault key.') | ||
c.argument('encryption_key_vault', help='The Uri of the KeyVault.') | ||
c.argument('encryption_key_version', help='The version of the KeyVault key. Use the latest version by default.') | ||
c.argument('identity_client_id', help='Client id of the managed identity with wrap and unwrap access to encryption key. Use system assigned identity by default.') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ID There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You mean just name the argument "--id"? It looks too vague and maybe we can use "--identity" and explain this should be the client of the managed identity?. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry. I should make my advice clear. I mean usually ID is upper case. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed. |
||
|
||
with self.argument_context('appconfig identity assign') as c: | ||
c.argument('identities', arg_type=identities_arg_type) | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,26 @@ | ||
{ | ||
"Color": "Red", | ||
"Region": "West US", | ||
"FeatureManagement": { | ||
"Beta": false, | ||
"Percentage": true, | ||
"Timestamp": { | ||
"EnabledFor": [ | ||
{ | ||
"Parameters": { | ||
"EndTime": "2019-09-01T00:00:00Z", | ||
"StartTime": "2019-01-01T00:00:00Z" | ||
"StartTime": "2019-01-01T00:00:00Z", | ||
"EndTime": "2019-09-01T00:00:00Z" | ||
}, | ||
"Name": "Local Tests" | ||
}, | ||
{ | ||
"Parameters": { | ||
"EndTime": "2019-11-01T00:00:00Z", | ||
"StartTime": "2019-09-02T00:00:00Z" | ||
"StartTime": "2019-09-02T00:00:00Z", | ||
"EndTime": "2019-11-01T00:00:00Z" | ||
}, | ||
"Name": "Production Tests" | ||
} | ||
] | ||
} | ||
}, | ||
"Color": "Red", | ||
"Region": "West US" | ||
}, | ||
"Beta": false | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
#Mon Feb 03 18:35:05 Pacific Standard Time 2020 | ||
feature-management.FeatureSample.enabled-for[2].Name=Filter@3 | ||
feature-management.FeatureSample.enabled-for[3].Name=filter.4 | ||
#Fri Feb 07 17:46:38 Pacific Standard Time 2020 | ||
feature-management.TrueFeature=true | ||
Region=West US | ||
feature-management.FalseFeature=false | ||
feature-management.FeatureSample.enabled-for[3].Parameters.dotInFilter.Param=? | ||
feature-management.FeatureSample.enabled-for[0].Name=Filter1 | ||
feature-management.FeatureSample.enabled-for[0].Parameters.paramforfilter1=value1 | ||
Color=Red | ||
feature-management.FeatureSample.enabled-for[0].Name=Filter1 | ||
feature-management.FeatureSample.enabled-for[3].Parameters.EmptyValue= | ||
feature-management.FeatureSample.enabled-for[0].Parameters.paramforfilter1=value1 | ||
feature-management.TrueFeature=true | ||
feature-management.FeatureSample.enabled-for[3].Parameters.dotInFilter.Param=? | ||
feature-management.FeatureSample.enabled-for[2].Name=Filter@3 | ||
feature-management.FeatureSample.enabled-for[1].Name=Filter2 | ||
feature-management.FeatureSample.enabled-for[3].Name=filter.4 | ||
feature-management.FalseFeature=false |
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are trying to keep consistent with
az storage account update
as below https://github.com/Azure/azure-cli/blob/dev/src/azure-cli/azure/cli/command_modules/storage/_params.py#L210 As cmk is kind of new required features for all Azure services, we don't want to invert our own way.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. I should make my advice clear. I mean usually URI is upper case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.