Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quantum] Ship peer dependencies in vendored sdks folder (25369) #8041

Conversation

warren-jones
Copy link
Contributor

@warren-jones warren-jones commented Oct 1, 2024

Original description from User Story 25369:

Azure CLI team:

Could you help vendor(copy) the Azure-related packages to the quantum extensions' vendor directory?

We require that all Azure-related packages be directly copied to the vendor directory; otherwise, there might be conflicts with the dependencies in the main repo.

This may cause users to be unable to use the extension, and may also cause the automatic update of the extension documentation to fail.

The quantum extension has directly set azure-storage-blob as a dependency: link to the setup.py file.

This is the PR submitted by the k8s-runtime team. You can refer to it to make the necessary modifications.

Changes for this PR:

  • Copy the azure.storage.blob files to src\quantum\azext_quantum\vendored_sdks\azure_storage_blob
  • Modify the associated from ... import statement in src\quantum\azext_quantum\_storage.py
  • Remove the DEPENDENCIES statement in src\quantum\setup.py
  • Create a wiki page to explain how to update vendored_sdks\azure_storage_blob in the future.

New wiki: How to update the Azure storage blob client

No changes will be perceived by customers.
A Quantum CLI extension release will follow this PR in a subsequent Release PR.


Related commands

az quantum run
az quantum execute
az quantum job submit


General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

Copy link

azure-client-tools-bot-prd bot commented Oct 1, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @warren-jones,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @warren-jones,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Copy link

github-actions bot commented Oct 1, 2024

Hi @warren-jones

Release Suggestions

Module: quantum

  • Please log updates into to src/quantum/HISTORY.rst
  • Update VERSION to 1.0.0b4 in src/quantum/setup.py

Notes

@yonzhan yonzhan requested a review from jsntcy October 1, 2024 04:55
@yonzhan
Copy link
Collaborator

yonzhan commented Oct 1, 2024

Quantum

@warren-jones warren-jones marked this pull request as ready for review October 8, 2024 16:18
@warren-jones warren-jones changed the title [Draft - Do Not Merge] [Quantum] Ship peer dependencies in vendored sdks folder (25369) [Quantum] Ship peer dependencies in vendored sdks folder (25369) Oct 8, 2024
@warren-jones
Copy link
Contributor Author

HISTORY.rst and setup.py updates will accompany an upcoming release PR as is customary in our extension-release workflow.

@kairu-ms kairu-ms merged commit 8ef7a29 into Azure:main Oct 11, 2024
20 checks passed
@warren-jones warren-jones mentioned this pull request Oct 14, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Quantum az quantum
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants