-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Container app] az containerapp job update
: Support job update in extension
#7656
Merged
zhoxing-ms
merged 8 commits into
Azure:main
from
Greedygre:xinyu/20240522_refactor_job_update
Jun 5, 2024
Merged
[Container app] az containerapp job update
: Support job update in extension
#7656
zhoxing-ms
merged 8 commits into
Azure:main
from
Greedygre:xinyu/20240522_refactor_job_update
Jun 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Azure CLI Extensions Breaking Change Test
|
Hi @Greedygre, |
Container app |
microsoft-github-policy-service
bot
requested review from
yonzhan,
wangzelin007,
yanzhudd,
zhoxing-ms,
jsntcy,
ruslany,
sanchitmehta,
ebencarek,
JennyLawrance,
howang-ms,
vinisoto,
chinadragon0515,
vturecek and
torosent
May 23, 2024 07:24
Greedygre
changed the title
[Container app]
{Container app} May 23, 2024
az containerapp job update
: Refactor job update in extensionaz containerapp job update
: Refactor job update in extension
microsoft-github-policy-service
bot
requested review from
pagariyaalok,
Juliehzl and
jijohn14
May 23, 2024 07:24
|
Greedygre
force-pushed
the
xinyu/20240522_refactor_job_update
branch
from
May 23, 2024 08:17
63845f2
to
4a3df62
Compare
anandanthony
approved these changes
May 23, 2024
yanzhudd
reviewed
May 24, 2024
Greedygre
changed the title
{Container app}
[Container app] May 24, 2024
az containerapp job update
: Refactor job update in extensionaz containerapp job update
: Support job update in extension
njuCZ
approved these changes
Jun 4, 2024
Wait for PR #7679 merge to fix the CI. |
Hi @zhoxing-ms This pr has been reviewed and approved inner our team, can you help to review and merge it when you have chance? |
zhoxing-ms
approved these changes
Jun 5, 2024
liorstauber
pushed a commit
to liorstauber/azure-cli-extensions
that referenced
this pull request
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.