Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Container app] az containerapp job update: Support job update in extension #7656

Merged
merged 8 commits into from
Jun 5, 2024

Conversation

Greedygre
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented May 23, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @Greedygre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented May 23, 2024

Container app

@Greedygre Greedygre changed the title [Container app] az containerapp job update: Refactor job update in extension {Container app} az containerapp job update: Refactor job update in extension May 23, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label May 23, 2024
Copy link

github-actions bot commented May 23, 2024

⚠️ Release Suggestions

Module: containerapp

  • Update VERSION to 1.0.0b1 in src/containerapp/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@Greedygre Greedygre force-pushed the xinyu/20240522_refactor_job_update branch from 63845f2 to 4a3df62 Compare May 23, 2024 08:17
@Greedygre Greedygre changed the title {Container app} az containerapp job update: Refactor job update in extension [Container app] az containerapp job update: Support job update in extension May 24, 2024
@Greedygre
Copy link
Contributor Author

Wait for PR #7679 merge to fix the CI.

@Greedygre
Copy link
Contributor Author

Hi @zhoxing-ms

This pr has been reviewed and approved inner our team, can you help to review and merge it when you have chance?
Thanks!

@zhoxing-ms zhoxing-ms merged commit f09ee0b into Azure:main Jun 5, 2024
15 of 16 checks passed
liorstauber pushed a commit to liorstauber/azure-cli-extensions that referenced this pull request Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants