Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s-configuration] BREAKING CHANGE: az k8s-configuration create: Removal of create cmd for flux v1 #7406

Merged
merged 4 commits into from
May 20, 2024

Conversation

bavneetsingh16
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Mar 22, 2024

❌Azure CLI Extensions Breaking Change Test
❌k8s-configuration
rule cmd_name rule_message suggest_message
1002 - CmdRemove k8s-configuration create cmd k8s-configuration create removed please confirm cmd k8s-configuration create removed

Copy link

Hi @bavneetsingh16,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 22, 2024

k8s-configuration breaking change

Copy link

github-actions bot commented Mar 27, 2024

For more info about extension versioning, please refer to Extension version schema

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 10, 2024
@AllyW
Copy link
Member

AllyW commented May 17, 2024

❌Azure CLI Extensions Breaking Change Test

❌k8s-configuration

rule
cmd_name
rule_message
suggest_message

1002 - CmdRemove
k8s-configuration create
cmd k8s-configuration create removed
please confirm cmd k8s-configuration create removed

breaking change in new release should increase the major version number to be 2.0.0. For cli extension versioning shcema, please refer to Extension version schema

@bavneetsingh16 bavneetsingh16 requested a review from AllyW May 17, 2024 02:39
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label May 17, 2024
@yanzhudd
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@zhoxing-ms zhoxing-ms added ADO Issue is documented on MSFT ADO for internal tracking and removed ADO Issue is documented on MSFT ADO for internal tracking labels May 20, 2024
@yanzhudd yanzhudd merged commit da5f8ab into Azure:main May 20, 2024
18 of 19 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ k8s-configuration ] : https://dev.azure.com/azclitools/release/_build/results?buildId=159872&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants