Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS}: Fix the issue that the value passed by option --os-sku in command az aks nodepool update is not processed #6964

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented Nov 8, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

{AKS}: Fix the issue that the value passed by option --os-sku in command az aks nodepool update is not processed.
Bug fix for PR #6944.

Related command

az aks nodepool update

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 8, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @FumingZhang,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 8, 2023

AKS

@FumingZhang
Copy link
Member Author

Queued live test (case test_aks_update_agentpool_os_sku) to verify the change. Test passed.

@zhoxing-ms zhoxing-ms merged commit d62f770 into Azure:main Nov 8, 2023
15 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Nov 8, 2023

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=105186&view=results

@FumingZhang FumingZhang deleted the fuming/fix-update-ossku-1108 branch January 4, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants