Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{connectedk8s} log debug if 'arcConfigEndpoint' doesn't exist #6949

Merged

Conversation

TheOnlyWei
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az connectedk8s

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 6, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @TheOnlyWei,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 6, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@TheOnlyWei TheOnlyWei force-pushed the connectedk8s-check-arcConfigEndpoint branch from fd9e800 to 2d0c363 Compare November 6, 2023 23:17
@wangzelin007
Copy link
Member

Hi @TheOnlyWei,
I have no problem with the PR to fix this problem.
But what I am more concerned about is, should we also check other properties such as arcHybridIdentityServiceEndpoint, relayEndpointSuffix, loginEndpoint to avoid similar errors from happening again?

@yonzhan yonzhan requested a review from jiasli November 7, 2023 06:27
@wangzelin007 wangzelin007 changed the title log debug if 'arcConfigEndpoint' doesn't exist {connectedk8s} log debug if 'arcConfigEndpoint' doesn't exist Nov 8, 2023
@wangzelin007 wangzelin007 merged commit 318cb84 into Azure:main Nov 8, 2023
14 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Nov 8, 2023

[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=104946&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants