Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[containerapp] 'az containerapp job create': Fix problem of parsing parameters minExecutions and maxExecutions from --yaml #6941

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

anandanthony
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 2, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @anandanthony,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 2, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@Greedygre
Copy link
Contributor

Greedygre commented Nov 7, 2023

Recommend title:

[containerapp] 'az containerapp job create': fix problem of parsing parameters minExecutions and maxExecutions from --yaml

@Greedygre
Copy link
Contributor

Please fix the conflict.

@anandanthony anandanthony changed the title fix for yaml containing min max execution property [containerapp] 'az containerapp job create': fix problem of parsing parameters minExecutions and maxExecutions from --yaml Nov 7, 2023
@anandanthony anandanthony changed the title [containerapp] 'az containerapp job create': fix problem of parsing parameters minExecutions and maxExecutions from --yaml [containerapp] 'az containerapp job create': Fix problem of parsing parameters minExecutions and maxExecutions from --yaml Nov 7, 2023
@Greedygre
Copy link
Contributor

Hi @zhoxing-ms @yanzhudd
Could you please help review and merge this PR? Thanks.

@wangzelin007 wangzelin007 changed the title [containerapp] 'az containerapp job create': Fix problem of parsing parameters minExecutions and maxExecutions from --yaml [containerapp] az containerapp job create: Fix problem of parsing parameters minExecutions and maxExecutions from --yaml Nov 7, 2023
@wangzelin007 wangzelin007 changed the title [containerapp] az containerapp job create: Fix problem of parsing parameters minExecutions and maxExecutions from --yaml [containerapp] 'az containerapp job create': Fix problem of parsing parameters minExecutions and maxExecutions from --yaml Nov 7, 2023
@zhoxing-ms zhoxing-ms merged commit 4c69703 into Azure:main Nov 7, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants