{AKS} az aks update: Add --network-plugin to support updating cluster networking settings
#6936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-lloyd
requested review from
andyliuliming and
FumingZhang
as code owners
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks update | cmd aks update added parameter network_plugin |
|
Hi @tyler-lloyd, |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
yanzhudd and
yonzhan
|
AKS |
microsoft-github-policy-service
bot
requested review from
jsntcy,
kairu-ms and
necusjz
tyler-lloyd
commented
Nov 1, 2023
| @@ -12,6 +12,7 @@ To release a new version, please select a new version number (usually plus 1 to | |||
| Pending | |||
| +++++++ | |||
| * Vendor new SDK and bump API version to 2023-09-02-preview. | |||
| * Add `--network-plugin` to the `az aks update` command. | |||
There was a problem hiding this comment.
@zhoxing-ms , @FumingZhang - should I just bump this to 0.5.168 or does that happen elsewhere?
|
edit: now includes a live test since the feature is rolling out. |
tyler-lloyd
force-pushed
the
update-network-plugin
branch
from
28dbe7f to
aefc40a
Compare
zhoxing-ms
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks update --network-plugin azureGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.