Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networkcloud extension update to support new 2023-10-01-preview APIs #6908

Merged
merged 7 commits into from
Nov 8, 2023

Conversation

mbashtovaya
Copy link
Member

@mbashtovaya mbashtovaya commented Oct 26, 2023

…-10-01-preview APIs


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 26, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️networkcloud
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd networkcloud baremetalmachine list cmd networkcloud baremetalmachine list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkcloud baremetalmachine list cmd networkcloud baremetalmachine list added parameter pagination_token
⚠️ 1006 - ParaAdd networkcloud cloudservicesnetwork list cmd networkcloud cloudservicesnetwork list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkcloud cloudservicesnetwork list cmd networkcloud cloudservicesnetwork list added parameter pagination_token
⚠️ 1006 - ParaAdd networkcloud cluster baremetalmachinekeyset list cmd networkcloud cluster baremetalmachinekeyset list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkcloud cluster baremetalmachinekeyset list cmd networkcloud cluster baremetalmachinekeyset list added parameter pagination_token
⚠️ 1006 - ParaAdd networkcloud cluster bmckeyset list cmd networkcloud cluster bmckeyset list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkcloud cluster bmckeyset list cmd networkcloud cluster bmckeyset list added parameter pagination_token
⚠️ 1006 - ParaAdd networkcloud cluster create cmd networkcloud cluster create added parameter runtime_protection
⚠️ 1006 - ParaAdd networkcloud cluster create cmd networkcloud cluster create added parameter secret_archive
⚠️ 1006 - ParaAdd networkcloud cluster create cmd networkcloud cluster create added parameter update_strategy
⚠️ 1006 - ParaAdd networkcloud cluster list cmd networkcloud cluster list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkcloud cluster list cmd networkcloud cluster list added parameter pagination_token
⚠️ 1006 - ParaAdd networkcloud cluster metricsconfiguration list cmd networkcloud cluster metricsconfiguration list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkcloud cluster metricsconfiguration list cmd networkcloud cluster metricsconfiguration list added parameter pagination_token
⚠️ 1001 - CmdAdd networkcloud cluster scan-runtime cmd networkcloud cluster scan-runtime added
⚠️ 1006 - ParaAdd networkcloud cluster update cmd networkcloud cluster update added parameter runtime_protection
⚠️ 1006 - ParaAdd networkcloud cluster update cmd networkcloud cluster update added parameter secret_archive
⚠️ 1006 - ParaAdd networkcloud cluster update cmd networkcloud cluster update added parameter update_strategy
⚠️ 1006 - ParaAdd networkcloud clustermanager list cmd networkcloud clustermanager list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkcloud clustermanager list cmd networkcloud clustermanager list added parameter pagination_token
⚠️ 1006 - ParaAdd networkcloud kubernetescluster agentpool list cmd networkcloud kubernetescluster agentpool list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkcloud kubernetescluster agentpool list cmd networkcloud kubernetescluster agentpool list added parameter pagination_token
⚠️ 1006 - ParaAdd networkcloud kubernetescluster agentpool update cmd networkcloud kubernetescluster agentpool update added parameter generate_ssh_keys
⚠️ 1006 - ParaAdd networkcloud kubernetescluster agentpool update cmd networkcloud kubernetescluster agentpool update added parameter ssh_dest_key_path
⚠️ 1006 - ParaAdd networkcloud kubernetescluster agentpool update cmd networkcloud kubernetescluster agentpool update added parameter ssh_key_values
⚠️ 1006 - ParaAdd networkcloud kubernetescluster list cmd networkcloud kubernetescluster list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkcloud kubernetescluster list cmd networkcloud kubernetescluster list added parameter pagination_token
⚠️ 1006 - ParaAdd networkcloud kubernetescluster update cmd networkcloud kubernetescluster update added parameter generate_ssh_keys
⚠️ 1006 - ParaAdd networkcloud kubernetescluster update cmd networkcloud kubernetescluster update added parameter ssh_dest_key_path
⚠️ 1006 - ParaAdd networkcloud kubernetescluster update cmd networkcloud kubernetescluster update added parameter ssh_key_values
⚠️ 1006 - ParaAdd networkcloud l2network list cmd networkcloud l2network list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkcloud l2network list cmd networkcloud l2network list added parameter pagination_token
⚠️ 1006 - ParaAdd networkcloud l3network list cmd networkcloud l3network list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkcloud l3network list cmd networkcloud l3network list added parameter pagination_token
⚠️ 1006 - ParaAdd networkcloud rack list cmd networkcloud rack list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkcloud rack list cmd networkcloud rack list added parameter pagination_token
⚠️ 1006 - ParaAdd networkcloud racksku list cmd networkcloud racksku list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkcloud racksku list cmd networkcloud racksku list added parameter pagination_token
⚠️ 1006 - ParaAdd networkcloud storageappliance list cmd networkcloud storageappliance list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkcloud storageappliance list cmd networkcloud storageappliance list added parameter pagination_token
⚠️ 1006 - ParaAdd networkcloud trunkednetwork list cmd networkcloud trunkednetwork list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkcloud trunkednetwork list cmd networkcloud trunkednetwork list added parameter pagination_token
⚠️ 1006 - ParaAdd networkcloud virtualmachine console list cmd networkcloud virtualmachine console list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkcloud virtualmachine console list cmd networkcloud virtualmachine console list added parameter pagination_token
⚠️ 1006 - ParaAdd networkcloud virtualmachine list cmd networkcloud virtualmachine list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkcloud virtualmachine list cmd networkcloud virtualmachine list added parameter pagination_token
⚠️ 1006 - ParaAdd networkcloud volume list cmd networkcloud volume list added parameter pagination_limit
⚠️ 1006 - ParaAdd networkcloud volume list cmd networkcloud volume list added parameter pagination_token

@azure-client-tools-bot-prd
Copy link

Hi @mbashtovaya,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 26, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@mbashtovaya
Copy link
Member Author

Corresponding aaz updates: Azure/aaz#329

@mbashtovaya mbashtovaya marked this pull request as ready for review October 26, 2023 16:25
@mbashtovaya
Copy link
Member Author

@kairu-ms we are ready to release. Please merge this and Azure/aaz#329 at your earliest convenience.

@kairu-ms kairu-ms merged commit 728cad1 into Azure:main Nov 8, 2023
14 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Nov 8, 2023

[Release] Update index.json for extension [ networkcloud ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=104961&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants