Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dataprotection] Added '-v' option for all --vault-name parameters #6897

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

zubairabid
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az dataprotection

Across all commands, the --vault-name option did not have a consistent shorthand. In the backup module, we use -v. Replicating that over to here.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 25, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️dataprotection
rule cmd_name rule_message suggest_message
⚠️ 1010 - ParaPropUpdate dataprotection backup-instance adhoc-backup cmd dataprotection backup-instance adhoc-backup update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection backup-instance create cmd dataprotection backup-instance create update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection backup-instance delete cmd dataprotection backup-instance delete update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection backup-instance deleted-backup-instance list cmd dataprotection backup-instance deleted-backup-instance list update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection backup-instance deleted-backup-instance show cmd dataprotection backup-instance deleted-backup-instance show update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection backup-instance deleted-backup-instance undelete cmd dataprotection backup-instance deleted-backup-instance undelete update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection backup-instance list cmd dataprotection backup-instance list update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection backup-instance restore trigger cmd dataprotection backup-instance restore trigger update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection backup-instance resume-protection cmd dataprotection backup-instance resume-protection update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection backup-instance show cmd dataprotection backup-instance show update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection backup-instance stop-protection cmd dataprotection backup-instance stop-protection update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection backup-instance suspend-backup cmd dataprotection backup-instance suspend-backup update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection backup-instance update cmd dataprotection backup-instance update update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection backup-instance wait cmd dataprotection backup-instance wait update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection backup-policy delete cmd dataprotection backup-policy delete update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection backup-policy list cmd dataprotection backup-policy list update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection backup-policy show cmd dataprotection backup-policy show update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection backup-policy update cmd dataprotection backup-policy update update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection job list cmd dataprotection job list update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection job show cmd dataprotection job show update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection recovery-point list cmd dataprotection recovery-point list update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection recovery-point show cmd dataprotection recovery-point show update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']
⚠️ 1010 - ParaPropUpdate dataprotection restorable-time-range find cmd dataprotection restorable-time-range find update parameter vault_name: updated property options from ['--vault-name'] to ['--vault-name', '-v']

@azure-client-tools-bot-prd
Copy link

Hi @zubairabid,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 25, 2023

dataprotection

@evelyn-ys evelyn-ys merged commit 42d12ff into Azure:main Oct 26, 2023
14 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ dataprotection ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=99991&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants