Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[containerapp] az containerapp service milvus: Add support for milvus dev service (#6863) #6893

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

Greedygre
Copy link
Contributor

@Greedygre Greedygre commented Oct 24, 2023

This reverts commit d6d11c9.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 24, 2023

❌Azure CLI Extensions Breaking Change Test
❌containerapp
rule cmd_name rule_message suggest_message
1012 - SubgroupRemove containerapp service milvus sub group containerapp service milvus removed please confirm sub group containerapp service milvus removed

@azure-client-tools-bot-prd
Copy link

Hi @Greedygre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 24, 2023

containerapp

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Oct 24, 2023
@Greedygre Greedygre changed the title Revert "[containerapp] az containerapp service milvus: Add support fo… Revert "[containerapp] az containerapp service milvus: Add support for milvus dev service (#6863) Oct 24, 2023
@yanzhudd yanzhudd merged commit e6c6870 into Azure:main Oct 24, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants