-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network Fabric Extension: Reverting attribute name change back as we need to keep the swagger naming in managed network fabric extension. #6887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aming in managed network fabric extension
❌Azure CLI Extensions Breaking Change Test
|
microsoft-github-policy-service
bot
requested review from
yonzhan,
jsntcy,
kairu-ms and
necusjz
October 21, 2023 07:40
Thank you for your contribution! We will review the pull request and get back to you soon. |
smylsamy
changed the title
Reverting attribute name change back as we need to keep the swagger naming in managed network fabric extension.
Network Fabric Extension: Reverting attribute name change back as we need to keep the swagger naming in managed network fabric extension.
Oct 21, 2023
kairu-ms
approved these changes
Oct 23, 2023
[Release] Update index.json for extension [ managednetworkfabric ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=98848&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Reverting attribute name change back as we need to keep the swagger naming in managed network fabric extension
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.