Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Containerapp} az containerapp job: Fix test for event job default #6874

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

p-bouchon
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 18, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @p-bouchon,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 18, 2023

Containerapp

@Greedygre
Copy link
Contributor

Recommend title: {Containerapp} Fix test for event job default
PR title guidance: https://github.com/Azure/azure-cli/blob/f9a4685d6bfee8bd5b8eff867f40a7d674515dae/doc/authoring_command_modules/README.md#format-pr-title

@Greedygre
Copy link
Contributor

Hi @yanzhudd
Could you help to review and approve and merge it, thanks.
BTW, Could you help to change the title for this PR? Because it will not impact the cx.

@p-bouchon p-bouchon changed the title [Containerapp] Fix test for event job default {Containerapp} Fix test for event job default Oct 20, 2023
@yanzhudd yanzhudd changed the title {Containerapp} Fix test for event job default {Containerapp} az containerapp job: Fix test for event job default Oct 23, 2023
@yanzhudd yanzhudd merged commit 5224355 into Azure:main Oct 23, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants