Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connectedvmware] Using stable swagger in vendored_sdks #6854

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

nascarsayan
Copy link
Contributor

@nascarsayan nascarsayan commented Oct 11, 2023

Update the vendored_sdks for connectedvmware with the swagger for the stable API version.
Not releasing the changes to the customers yet, we'll do that at the time of GA.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Oct 11, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @nascarsayan,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 11, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@nascarsayan nascarsayan changed the title stable swagger sdk [connectedvmware] Using stable swagger in vendored_sdks Oct 11, 2023
@nascarsayan nascarsayan marked this pull request as ready for review October 11, 2023 06:13
@kairu-ms kairu-ms merged commit 336d3b3 into Azure:main Oct 11, 2023
14 checks passed
bgashirabake pushed a commit to bgashirabake/azure-cli-extensions that referenced this pull request Oct 16, 2023
* stable swagger sdk

* rerun tests with new API version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants