-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ContainerApp] az containerapp replica count: app/revision scope #6828
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
207428e
app/revision level replica count
Juancpani 5ceff5b
added help text
Juancpani 773d1cb
help changes
Juancpani b8ef608
comment fixes: exception handling
Juancpani 82076e3
added latestRevisionName validation
Juancpani 469d46b
static fix
Juancpani b1f221d
replica count history
Juancpani 0fad2b1
static fix
Juancpani fb80de8
Merge branch 'main' into replica-count
Juancpani b194605
added preview flag
Juancpani 2224224
app/revision level replica count
Juancpani f0b794e
added help text
Juancpani faca0c5
help changes
Juancpani ee90d30
comment fixes: exception handling
Juancpani c0e474c
added latestRevisionName validation
Juancpani feede44
static fix
Juancpani ff5b0c0
replica count history
Juancpani 77258aa
static fix
Juancpani adcba8b
added preview flag
Juancpani f50191c
added testing and extra validation
Juancpani b838fc8
test recordings
Juancpani 805a413
Merge branch 'replica-count' of https://github.com/Juancpani/azure-cl…
Juancpani 499ec2b
app/revision level replica count
Juancpani 4b18e47
added help text
Juancpani 350aed8
comment fixes: exception handling
Juancpani fb67873
added latestRevisionName validation
Juancpani a2274ac
static fix
Juancpani 27adba1
static fix
Juancpani 41088fb
Merge branch 'replica-count' of https://github.com/Juancpani/azure-cl…
Juancpani 2dd2b25
static analysis fix
Juancpani c7dd991
remove duplicate function
Juancpani 85076f4
Update src/containerapp/HISTORY.rst
Juancpani 6170cfc
Merge branch 'main' into replica-count
Juancpani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity, I would like to confirm why the
projects
folder was added at that time? @Juancpani @GreedygreThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Juancpani
Is this
projects
folder added by mistake?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the projects folder addition was a mistake. We should remove it.