Add apms parameter for Spring Cloud Gateway #6804
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| spring gateway update | cmd spring gateway update added parameter apms |
|
Hi @ninpan-ms, |
|
Hi @ninpan-ms, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
ninpan-ms
force-pushed
the
ninpan/service-level-apm
branch
from
6494d79 to
8d0a096
Compare
| uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.Storage/storageAccounts/clitest000002/listKeys?api-version=2022-09-01&$expand=kerb | ||
| uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.Storage/storageAccounts/clitest000002/listKeys?api-version=2023-01-01&$expand=kerb |
There was a problem hiding this comment.
Could you please recording this test instead of only replacing the api-version?
There was a problem hiding this comment.
This test is not related to the changes of this PR, changing API version to avoid test failed. Could we record this test in the next PR?
|
Could you add some test case for this new parameter? |
Test cases added |
|
[Release] Update index.json for extension [ spring ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=100761&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.