Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connectedvmware] Refresh sdk from public swagger #6664

Merged
merged 7 commits into from
Aug 21, 2023

Conversation

nascarsayan
Copy link
Contributor

Changes to connectedvmware extension:

  • Refresh sdk from latest public facing swagger
  • Raise better error types instead of CLIError
  • revamping get_resource_id utility function to take into account multiple children. Thoroughly verified its behaviour using unittests
  • If only tags are intended to be updated for vm, just update Machine tags, and dont call update for VMInstance.
  • machine.kind case insensitive check.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 21, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @nascarsayan,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 21, 2023

connectedvmware

@nascarsayan nascarsayan marked this pull request as ready for review August 21, 2023 06:39
@kairu-ms kairu-ms merged commit 7c8736c into Azure:main Aug 21, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ connectedvmware ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=84284&view=results

@nascarsayan nascarsayan deleted the dev/snaskar/nrm-pp-refresh-vmware branch August 21, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants