Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image integrity] add image integrity disable #6603

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Conversation

fseldow
Copy link
Contributor

@fseldow fseldow commented Aug 7, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks update --disable-image-integrity

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 7, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter disable_image_integrity

@azure-client-tools-bot-prd
Copy link

Hi @fseldow,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 7, 2023

image integrity

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, could you please add a live test case for this new option? May refer to the test case of image cleaner

src/aks-preview/setup.py Outdated Show resolved Hide resolved
@fseldow
Copy link
Contributor Author

fseldow commented Aug 8, 2023

The change looks good to me, could you please add a live test case for this new option? May refer to the test case of image cleaner

added

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

live test validation passed

@zhoxing-ms zhoxing-ms merged commit 45a41b4 into Azure:main Aug 11, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=81665&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants