-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
containerapp-preview remove containerapp-preview extension #6601
containerapp-preview remove containerapp-preview extension #6601
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about index.json?
Hi @zhoxing-ms Thanks a lot. |
@Greedygre Yes, please help submit a separate PR to remove it. |
I think it is safe to move. The containerapp-preview just exist for short time and no document is relate to it. |
035e45e
to
460f890
Compare
@wangzelin007 @zhoxing-ms please remove hack code for container-app-preview in cli core, too |
Hi @zhoxing-ms |
Thank you for reminding us. There seems no hack code in our cli core, but may be some hack code for linter and test tasks in our extension CI pipeline. @wangzelin007 Could you please help check it and remove these hack code? |
Create #6616 to revert hack code for containerapp-preview. |
Hi @zhoxing-ms |
1a6ceb4
to
a36a791
Compare
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.