Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerapp-preview remove containerapp-preview extension #6601

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

Greedygre
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 7, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@Greedygre Greedygre marked this pull request as ready for review August 7, 2023 10:45
@yonzhan
Copy link
Collaborator

yonzhan commented Aug 7, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Contributor

@Juliehzl Juliehzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about index.json?

@Greedygre
Copy link
Contributor Author

what about index.json?

Hi @zhoxing-ms
We are going to remove containerapp-preview extension in this PR.
We also need to remove the released extension for containerapp-preview.
Should I update the index.json by myself? Or CLI teams member will help to do that?

Thanks a lot.

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Aug 8, 2023

Should I update the index.json by myself?

@Greedygre Yes, please help submit a separate PR to remove it.
Additionally, if considering the possibility of a breaking change affecting customer automation scripts (break the usage of `az extension add -n containerapp-preview) , we can consider removing it in the next breaking change window (Ignite Sprint). If there are very few customers currently using it, then we can immediately remove it.

@howang-ms
Copy link

Should I update the index.json by myself?

@Greedygre Yes, please help submit a separate PR to remove it. Additionally, if considering the possibility of a breaking change affecting customer automation scripts (break the usage of `az extension add -n containerapp-preview) , we can consider removing it in the next breaking change window (Ignite Sprint). If there are very few customers currently using it, then we can immediately remove it.

I think it is safe to move. The containerapp-preview just exist for short time and no document is relate to it.

@Greedygre Greedygre force-pushed the xinyu/remove_containerapp_preview branch from 035e45e to 460f890 Compare August 8, 2023 11:15
@Greedygre Greedygre requested a review from kairu-ms as a code owner August 8, 2023 11:15
@Juliehzl
Copy link
Contributor

Juliehzl commented Aug 9, 2023

@wangzelin007 @zhoxing-ms please remove hack code for container-app-preview in cli core, too

@Greedygre
Copy link
Contributor Author

Hi @zhoxing-ms
Could you help to review and approve this pr? Thanks.

@zhoxing-ms
Copy link
Contributor

please remove hack code for container-app-preview in cli core, too

Thank you for reminding us. There seems no hack code in our cli core, but may be some hack code for linter and test tasks in our extension CI pipeline. @wangzelin007 Could you please help check it and remove these hack code?

@wangzelin007
Copy link
Member

remove hack code for container-app-preview

Create #6616 to revert hack code for containerapp-preview.

@Greedygre
Copy link
Contributor Author

Hi @zhoxing-ms
Please help to merge this PR. Thanks.

@Greedygre Greedygre force-pushed the xinyu/remove_containerapp_preview branch from 1a6ceb4 to a36a791 Compare August 9, 2023 06:10
@zhoxing-ms zhoxing-ms merged commit 8f413b4 into Azure:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants