Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for new azdev #6505

Closed
wants to merge 2 commits into from
Closed

Prepare for new azdev #6505

wants to merge 2 commits into from

Conversation

bebound
Copy link
Contributor

@bebound bebound commented Jul 12, 2023

Check if CI works in new azdev Azure/azure-cli-dev-tools#359

As pylint version bumps to 2.17, many new rules are added. I guess the service team may need to fix their code style when PR is submitted.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 12, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @bebound,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 12, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

# line break after binary operator effect on readability is subjective
W504
# line break occurred before a binary operator
W503
Copy link
Contributor Author

@bebound bebound Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why lots of W503 errors are raised in Static Analysis test.

/mnt/vss/_work/1/s/src/ssh/azext_ssh/ssh_info.py:144:26: W503 line break before binary operator
/mnt/vss/_work/1/s/src/datafactory/azext_datafactory/manual/custom.py:130:13: W503 line break before binary operator

@bebound
Copy link
Contributor Author

bebound commented Dec 13, 2023

In this PR, we found that the extension style check is not working for a long time.
It uses an ancient task

- bash: pip install wheel==0.30.0 pylint==1.9.5 flake8==3.5.0 requests  
displayName: 'Install wheel, pylint, flake8, requests'  
- bash: python scripts/ci/source_code_static_analysis.py

, which raises

File "/usr/local/lib/python3.6/site-packages/pylint/checkers/imports.py", line 712, in _check_imports_order
    isort_obj = isort.SortImports(
AttributeError: module 'isort' has no attribute 'SortImports'

This is fixed in #6509

Ref: PyCQA/isort#1273 (comment)

@bebound bebound closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants