Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{containerapp} Add new containerapp codeowners and remove old codeowners #5797

Merged
merged 1 commit into from
Jan 28, 2023

Conversation

StrawnSC
Copy link
Contributor


See title.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested a review from yonzhan January 23, 2023 20:45
@ghost ghost added the Auto-Assign Auto assign by bot label Jan 23, 2023
@ghost ghost requested a review from wangzelin007 January 23, 2023 20:45
@ghost ghost assigned zhoxing-ms Jan 23, 2023
@ghost ghost added this to the Jan 2023 (2023-02-07) milestone Jan 23, 2023
@ghost ghost added the ContainerApp label Jan 23, 2023
@ghost ghost requested review from zhoxing-ms and jsntcy January 23, 2023 20:45
@runefa runefa self-requested a review January 23, 2023 21:22
Copy link

@pagariyaalok pagariyaalok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 23, 2023

containerapp

@zhoxing-ms zhoxing-ms merged commit a25b8f7 into Azure:main Jan 28, 2023
@StrawnSC StrawnSC deleted the new-aca-codeowners branch January 31, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants