Fix for --unauthenticated-client-action V2 issue #5741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith404, rejectwith403
ghost
requested review from
ghost
added
the
|
webapp |
|
Rerecorded the live tests, CI is now passing. @zhoxing-ms, could you help with approving? |
|
@annzho Please add the description of PR into the |
|
@zhoxing-ms Have added the description of the new version in |
zhoxing-ms
reviewed
Jan 28, 2023
|
@zhoxing-ms, moved the version notes to top of history file, could you approve? |
zhoxing-ms
approved these changes
Feb 10, 2023
|
[Release] Update index.json for extension [ authV2 ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=33281&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, using
az webapp auth --unauthenticated-client-actionargument did not correctly update Unauthenticated Client Action configuration setting if the argument was set to RejectWith401, RejectWith404, or RejectWith403 due a naming mismatch between the CLI and the API surface.Previous issues raised for this: Azure/azure-cli#24086, Azure/azure-cli#21618
The fix was to rename some of the allowed values for --unauthenticated-client-action. Also added the Return403 value. Allowed Values: RedirectToLoginPage, AllowAnonymous, Return401, Return404, Return403
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az webapp auth updatecommand fix --unauthenticated-client-action argumentGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.