-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dns and outbound connect prechecks #5665
Merged
zhoxing-ms
merged 69 commits into
Azure:main
from
rohan-dassani:dns-and-outbound-connect-prechecks
Jan 30, 2023
Merged
Dns and outbound connect prechecks #5665
zhoxing-ms
merged 69 commits into
Azure:main
from
rohan-dassani:dns-and-outbound-connect-prechecks
Jan 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: src/connectedk8s/azext_connectedk8s/custom.py
modified: src/connectedk8s/setup.py
new file: src/connectedk8s/azext_connectedk8s/_precheckutils.py modified: src/connectedk8s/azext_connectedk8s/custom.py
modified: src/connectedk8s/azext_connectedk8s/custom.py
connectedk8s |
modified: src/connectedk8s/azext_connectedk8s/custom.py
…om/rohan-dassani/azure-cli-extensions into dns-and-outbound-connect-prechecks
modified: src/connectedk8s/azext_connectedk8s/_precheckutils.py
modified: src/connectedk8s/azext_connectedk8s/custom.py
modified: src/connectedk8s/azext_connectedk8s/_precheckutils.py
modified: src/connectedk8s/azext_connectedk8s/custom.py
sirireddy12
reviewed
Jan 5, 2023
modified: src/connectedk8s/azext_connectedk8s/_precheckutils.py modified: src/connectedk8s/azext_connectedk8s/_troubleshootutils.py modified: src/connectedk8s/azext_connectedk8s/_utils.py modified: src/connectedk8s/azext_connectedk8s/custom.py
modified: src/connectedk8s/azext_connectedk8s/_utils.py
…om/rohan-dassani/azure-cli-extensions into dns-and-outbound-connect-prechecks
modified: src/connectedk8s/azext_connectedk8s/_troubleshootutils.py modified: src/connectedk8s/azext_connectedk8s/_utils.py modified: src/connectedk8s/azext_connectedk8s/custom.py
modified: src/connectedk8s/azext_connectedk8s/_precheckutils.py modified: src/connectedk8s/azext_connectedk8s/_troubleshootutils.py modified: src/connectedk8s/azext_connectedk8s/_utils.py modified: src/connectedk8s/azext_connectedk8s/custom.py
modified: src/connectedk8s/azext_connectedk8s/_precheckutils.py modified: src/connectedk8s/azext_connectedk8s/_utils.py modified: src/connectedk8s/azext_connectedk8s/custom.py
modified: src/connectedk8s/azext_connectedk8s/custom.py
sirireddy12
reviewed
Jan 25, 2023
sirireddy12
reviewed
Jan 25, 2023
sirireddy12
reviewed
Jan 25, 2023
sirireddy12
reviewed
Jan 25, 2023
sirireddy12
reviewed
Jan 25, 2023
sirireddy12
reviewed
Jan 25, 2023
modified: src/connectedk8s/azext_connectedk8s/_troubleshootutils.py modified: src/connectedk8s/azext_connectedk8s/custom.py
sirireddy12
reviewed
Jan 25, 2023
sirireddy12
reviewed
Jan 25, 2023
sirireddy12
reviewed
Jan 25, 2023
sirireddy12
reviewed
Jan 25, 2023
sirireddy12
reviewed
Jan 25, 2023
modified: src/connectedk8s/azext_connectedk8s/_utils.py modified: src/connectedk8s/azext_connectedk8s/custom.py
modified: src/connectedk8s/azext_connectedk8s/_precheckutils.py modified: src/connectedk8s/azext_connectedk8s/_utils.py
modified: src/connectedk8s/azext_connectedk8s/_constants.py modified: src/connectedk8s/setup.py
sirireddy12
approved these changes
Jan 30, 2023
zhoxing-ms
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json
.