Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[containerapp] Fix 'NoneType object has no attribute get' error in az containerapp up with no ingress arguments #5646

Merged
merged 3 commits into from
Dec 26, 2022

Conversation

StrawnSC
Copy link
Contributor

@StrawnSC StrawnSC commented Dec 15, 2022

See title. Also fixes #5642


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…p with no ingress arguments
@StrawnSC StrawnSC requested a review from Juliehzl December 15, 2022 23:32
@ghost ghost requested a review from yonzhan December 15, 2022 23:32
@ghost ghost added the Auto-Assign Auto assign by bot label Dec 15, 2022
@ghost ghost requested a review from wangzelin007 December 15, 2022 23:32
@ghost ghost assigned zhoxing-ms Dec 15, 2022
@ghost ghost added the ContainerApp label Dec 15, 2022
@ghost ghost requested review from zhoxing-ms and jsntcy December 15, 2022 23:32
@yonzhan yonzhan added this to the Dec 2022 (2023-01-10) milestone Dec 16, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 16, 2022

containerapp

@yonzhan yonzhan requested a review from yanzhudd December 16, 2022 00:33
@zhoxing-ms zhoxing-ms merged commit 8470df3 into Azure:main Dec 26, 2022
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ containerapp ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=22099&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting registry for container app results in python error
8 participants