[Container App]: Add az containerapp ingress access-restriction group
#5546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial no dockerfile support for up * bump version * add to help text, history text * Fill in Cormac's link for oryx runtimes (see here microsoft/Oryx#1502) * pass target port to ACR task; add better error information * bump version * fix bug with containerapp create * add test case * bump version * Updated to preview api version and reran all tests. (Azure#147) * Ran tests. * Update src/containerapp/azext_containerapp/_clients.py Co-authored-by: Silas Strawn <[email protected]> Co-authored-by: Haroon Feisal <[email protected]> Co-authored-by: Silas Strawn <[email protected]> * resolve anthony's comments * Revert "`az containerapp up`: Support No Dockerfile Scenario" * Revert "Revert "`az containerapp up`: Support No Dockerfile Scenario"" * Added custom domain support to env create. * Updated param help group text. * Added test. * Wrote env update, wrote test for env update with custom domains. * Minor update. * Added help to env update. Co-authored-by: Silas Strawn <[email protected]> Co-authored-by: Haroon Feisal <[email protected]>
Migrating containerapp-compose into containerapp
Revert "Migrating containerapp-compose into containerapp"
…ure-cli-extensions into containerapp-0.3.12
* Finished feature. * Fixed comments. Co-authored-by: Haroon Feisal <[email protected]>
ghost
requested a review
from 
ghost
added
the
|
Container App |
StrawnSC
approved these changes
Nov 16, 2022
|
@zhoxing-ms Could you take a look at this? Want to get this released soon if possible. Thanks |
zhoxing-ms
reviewed
Nov 17, 2022
zhoxing-ms
reviewed
Nov 17, 2022
zhoxing-ms
reviewed
Nov 17, 2022
| @@ -249,6 +249,12 @@ def load_arguments(self, _): | |||
| c.argument('target_port', type=int, validator=validate_target_port, help="The application port used for ingress traffic.") | |||
| c.argument('exposed_port', type=int, help="Additional exposed port. Only supported by tcp transport protocol. Must be unique per environment if the app ingress is external.") | |||
|
|
|||
| with self.argument_context('containerapp ingress ip-restriction') as c: | |||
| c.argument('allow_access', help='Boolean indicating whether the ip security restriction allows or denies access.') | |||
There was a problem hiding this comment.
Could we define this parameter as action='store_true' ?
There was a problem hiding this comment.
This parameter changes frequently, and we wouldn't want the default behavior to change (i.e. customers might create an ip restriction that allows when they want to block an ip range)
There was a problem hiding this comment.
@haroonf If the design of this parameter is not stable and has not been finalized, please add the is_preview flag to it.
runefa
changed the title
az containerapp ingress ip-restriction groupaz containerapp ingress access-restriction group
anthonychu
approved these changes
Nov 17, 2022
Co-authored-by: Anthony Chu <[email protected]>
Co-authored-by: Anthony Chu <[email protected]>
Co-authored-by: Anthony Chu <[email protected]>
Co-authored-by: Anthony Chu <[email protected]>
Co-authored-by: Anthony Chu <[email protected]>
Co-authored-by: Anthony Chu <[email protected]>
Co-authored-by: Anthony Chu <[email protected]>
Co-authored-by: Anthony Chu <[email protected]>
Co-authored-by: Anthony Chu <[email protected]>
Let me know if there is anything else, thanks! |
zhoxing-ms
approved these changes
Nov 18, 2022
|
[Release] Update index.json for extension [ containerapp ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=15753&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.